Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754663AbcK3LiE (ORCPT ); Wed, 30 Nov 2016 06:38:04 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:60254 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbcK3Lh4 (ORCPT ); Wed, 30 Nov 2016 06:37:56 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Grygorii Strashko , Murali Karicheri , Santosh Shilimkar , Sekhar Nori , linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: ti: qmss: fix the case when !SMP Date: Wed, 30 Nov 2016 12:37:17 +0100 Message-ID: <5501170.dgvo5UdPBX@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20161129221508.10551-1-grygorii.strashko@ti.com> References: <20161129221508.10551-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DyIqASVJyWCEeKNf644xFSk7rP7KXNTwgeclXzCTR8CfpZO8jPo uqt38SERS479VsOVgeYTl9KKcxrY58TuMHGFTYwNVJxsIeAdLqrLwcQUEX4Wyed/0duiReP d9hbqNG+iwjnmirHjERwoWPK+OIHLW7xeQPRqxxCiNTSmECVYPdqBtWBjVEqNyB9GibesPD puBG2JofiuAG8bc7KXBUQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:vyT4e/2wB40=:jOjJgWPFA6CKxkKz6iqvQ6 z9Ai1hY9IVUj37Sw2AY8HmBmDHjnWfVPf3oLavoXeYilon37vEdC8nH3f1xTLnM3NPROkbf9C XtidxqxI4owarUiTz9v3PDyrU9/VyVNa5rAo6nZbgLJ8MfZiCMdgdFyjD6RploWkWqrxwHiA3 FHoVt8mbCrbnyf7sWMOlkpPD1SYMrTjk0HM8Wrfd7yfTTD1hnvnQb8gZwfGgkPj2osssUDmR5 hg7etZ/iTiNcVxFsLgMRY6VOEOaUAbqnbLtsk78cC+SueUXizv49LQAt77DwJlAJPzAnMJ9+x aBwBzyjlUVmhzDP1q3ZgKP2J5ilxqrAf+TeYKw5+b+CsWfXmvkMIgnCPtYZJ3dwClAe0+szbd hbuW3yVXW4xPP3LD0Xz7VU9OEs4NcmPfD1wE4k62IJV8kEoo5hT9tx2E5sNYY+F2iLLgb+LEC H4xNULrfXQWLQ+eVFBOYe465ZIqxeAt9FIVwFCPh6j4ET1ntIYqFduDHK4Gdzg/W3Iz44Xb/y VwcK0Xv0zg8atFZUrHI4ZuK9MA99LaGGQVzLy3HoFYNDgYiy3IsHPJhGv885waaxJtYvjgwkw 5KIOvV0cfZDahOmSLdn35wnA8lEbNvn/ZPIcjyvN9c+XXv6nUl9PAjPS7BkJgC2IAvNHo/dQ0 J7vQQ7k2ODP6JLU8xUM239S8nEqCw4RA8vPUBAeSNuM9qeRjHlZ748nv0+DChiRu/vn1PO4Im afOGZkrWr/U4lae8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 442 Lines: 13 On Tuesday, November 29, 2016 4:15:08 PM CET Grygorii Strashko wrote: > range->num_irqs++; > > - if (oirq.args_count == 3) > + if (IS_ENABLED(SMP) && oirq.args_count == 3) > range->irqs[i].cpu_map = > (oirq.args[2] & 0x0000ff00) >> 8; > I think you mean CONFIG_SMP, not SMP. With the change above, the code will never be executed. Arnd