Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755444AbcK3MTN (ORCPT ); Wed, 30 Nov 2016 07:19:13 -0500 Received: from mail-qk0-f170.google.com ([209.85.220.170]:34937 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbcK3MTM (ORCPT ); Wed, 30 Nov 2016 07:19:12 -0500 MIME-Version: 1.0 In-Reply-To: References: <1480132046-5406-1-git-send-email-a.mathur@samsung.com> From: Linus Walleij Date: Wed, 30 Nov 2016 13:19:10 +0100 Message-ID: Subject: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs To: Jonathan Cameron Cc: Aniroop Mathur , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , s.samuel@samsung.com, r.mahale@samsung.com, aniroop.mathur@gmail.com, Naveen Krishna Chatradhi , Linus Walleij , Vlad Dogaru Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 19 On Sun, Nov 27, 2016 at 11:51 AM, Jonathan Cameron wrote: > On 26/11/16 03:47, Aniroop Mathur wrote: [bmp280.c] >> /* Wait to make sure we started up properly */ >> - mdelay(data->start_up_time); >> + usleep_range(data->start_up_time, data->start_up_time + 100); > > As this in probe I doubt we really care. Could just set it longer to shut up the warnings. > Still would like some input from say Linus on this... Hm, I don't think it's a big issue... this works too it just looks overworked. On the runtime_resume() path we use msleep() instead which I guess is why it is not changed in this patch, but they have the same purpose. Yours, Linus Walleij