Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757110AbcK3NmD (ORCPT ); Wed, 30 Nov 2016 08:42:03 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35114 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbcK3Nlz (ORCPT ); Wed, 30 Nov 2016 08:41:55 -0500 Subject: Re: [PATCH 1/1] usb: return error code when platform_get_irq fails To: Pan Bian , linux-usb@vger.kernel.org, Greg Kroah-Hartman , Mathias Nyman , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC..." , Chunfeng Yun References: <1480424255-25059-1-git-send-email-bianpan2016@163.com> Cc: linux-kernel@vger.kernel.org From: Matthias Brugger Message-ID: <52a774c0-9bca-6d1b-a470-f07caefa5d3a@gmail.com> Date: Wed, 30 Nov 2016 14:41:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480424255-25059-1-git-send-email-bianpan2016@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 42 On 29/11/16 13:57, Pan Bian wrote: > In function xhci_mtk_probe(), variable ret takes the return value. Its > value should be negative on failures. However, when the call to function > platform_get_irq() fails, it does not set the error code, and 0 will be > returned. 0 indicates no error. As a result, the callers of function > xhci_mtk_probe() will not be able to detect the error. This patch fixes > the bug by assigning the return value of platform_get_irq() to variable > ret if it fails. > > Signed-off-by: Pan Bian > --- > drivers/usb/host/xhci-mtk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c > index 79959f1..f2365a4 100644 > --- a/drivers/usb/host/xhci-mtk.c > +++ b/drivers/usb/host/xhci-mtk.c > @@ -560,8 +560,10 @@ static int xhci_mtk_probe(struct platform_device *pdev) > goto disable_ldos; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) > + if (irq < 0) { > + ret = irq; > goto disable_clk; > + } > > /* Initialize dma_mask and coherent_dma_mask to 32-bits */ > ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); > Reviewed-by: Matthias Brugger Next time please make sure to send the patch to all relevant lists and people (get_maintainer.pl). Regards, Matthias