Date: Wed, 30 Nov 2016 14:54:48 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated
 ACCESS_ONCE
Message-ID: <20161130135448.GB1283@kroah.com>
References: <1479585168-7792-1-git-send-email-dave@stgolabs.net>
 <20161129192411.GB3155@kroah.com>
 <20161130134926.GA25118@linux-80c1.suse>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161130134926.GA25118@linux-80c1.suse>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 867
Lines: 27

On Wed, Nov 30, 2016 at 05:49:26AM -0800, Davidlohr Bueso wrote:
> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant drivers/base/.
> 
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> 
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> drivers/base/core.c          | 2 +-
> drivers/base/power/runtime.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)

What changed from v1?  Please always include it below the --- line to
keep maintainer's semi-sane.

Try again?

thanks,

greg k-h