Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757831AbcK3OXI (ORCPT ); Wed, 30 Nov 2016 09:23:08 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53760 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755449AbcK3OXB (ORCPT ); Wed, 30 Nov 2016 09:23:01 -0500 Date: Wed, 30 Nov 2016 15:23:11 +0100 From: Greg KH To: Davidlohr Bueso Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH v2] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE Message-ID: <20161130142311.GA24288@kroah.com> References: <1479585265-7906-1-git-send-email-dave@stgolabs.net> <20161129192426.GC3155@kroah.com> <20161130135054.GB25118@linux-80c1.suse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161130135054.GB25118@linux-80c1.suse> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 24 On Wed, Nov 30, 2016 at 05:50:54AM -0800, Davidlohr Bueso wrote: > With the new standardized functions, we can replace all ACCESS_ONCE() > calls across relevant drivers/usb/. > > ACCESS_ONCE() does not work reliably on non-scalar types. For example > gcc 4.6 and 4.7 might remove the volatile tag for such accesses during > the SRA (scalar replacement of aggregates) step: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > Update the new calls regardless of if it is a scalar type, this is > cleaner than having three alternatives. > > Signed-off-by: Davidlohr Bueso > --- > drivers/usb/class/cdc-wdm.c | 2 +- > drivers/usb/core/devio.c | 2 +- > drivers/usb/core/sysfs.c | 4 ++-- > drivers/usb/gadget/udc/gr_udc.c | 4 ++-- > drivers/usb/host/ohci-hcd.c | 2 +- > drivers/usb/host/uhci-hcd.h | 4 ++-- > 6 files changed, 9 insertions(+), 9 deletions(-) Same comment on your driver base patch, what changed from v1?