Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758006AbcK3Ocm (ORCPT ); Wed, 30 Nov 2016 09:32:42 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35855 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753958AbcK3Ocd (ORCPT ); Wed, 30 Nov 2016 09:32:33 -0500 From: Johan Hovold To: "David S. Miller" Cc: Giuseppe Cavallaro , Alexandre Torgue , Joachim Eastwood , Carlo Caione , Kevin Hilman , Maxime Coquelin , Maxime Ripard , Chen-Yu Tsai , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks Date: Wed, 30 Nov 2016 15:29:48 +0100 Message-Id: <1480516195-27696-1-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2091 Lines: 45 This series fixes a number of issues with the stmmac-driver probe error handling, which for example left clocks enabled after probe failures. The final patch fixes a failure to deregister and free any fixed-link PHYs that were registered during probe on probe errors and on driver unbind. It also fixes a related of-node leak on late probe errors. This series depends on the of_phy_deregister_fixed_link() helper that was just merged to net. As mentioned earlier, one staging driver also suffers from a similar leak and can be fixed up once the above mentioned helper hits mainline. Note that these patches have only been compile tested. Johan Johan Hovold (7): net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe errors net: ethernet: stmmac: dwmac-sti: fix probe error path net: ethernet: stmmac: dwmac-rk: fix probe error path net: ethernet: stmmac: dwmac-generic: fix probe error path net: ethernet: stmmac: dwmac-meson8b: fix probe error path net: ethernet: stmmac: platform: fix outdated function header net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks .../net/ethernet/stmicro/stmmac/dwmac-generic.c | 17 ++++++++-- .../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 25 ++++++++++---- .../net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 17 ++++++++-- drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 23 ++++++++++--- .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 32 +++++++++++++----- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 21 +++++++++--- .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 39 ++++++++++++++-------- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 23 ++++++++++--- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 19 ++++++++--- drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 26 +++++++++++---- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 - .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 33 +++++++++++++++--- .../net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 ++ 13 files changed, 215 insertions(+), 63 deletions(-) -- 2.7.3