Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758092AbcK3QFe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 30 Nov 2016 11:05:34 -0500
Received: from mail-wj0-f174.google.com ([209.85.210.174]:34611 "EHLO
        mail-wj0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757657AbcK3QF1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Nov 2016 11:05:27 -0500
Subject: Re: [PATCH v2 1/4] drm: Add support for Amlogic Meson Graphic
 Controller
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
References: <1480520625-13269-1-git-send-email-narmstrong@baylibre.com>
 <1480520625-13269-2-git-send-email-narmstrong@baylibre.com>
 <3713265.h5djxipShb@avalon>
Cc: airlied@linux.ie, khilman@baylibre.com, carlo@caione.org,
        dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        victor.wan@amlogic.com, jerry.cao@amlogic.com, Xing.Xu@amlogic.com,
        daniel@ffwll.ch
From: Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <dd2076e9-6ce7-96d6-2584-3c2642f6b5ac@baylibre.com>
Date: Wed, 30 Nov 2016 17:05:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <3713265.h5djxipShb@avalon>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 366
Lines: 15

On 11/30/2016 05:03 PM, Laurent Pinchart wrote:
> Hi Neil,
> 
> Thank you for the patch.
> 
> I'm afraid I don't have time for a complete review, but could you please get 
> rid of the of_machine_is_compatible() calls and match on the VPU compatible 
> string instead ?

Oops, I knew I forgot to change this one...

I will get rid of these for the v3.

Thanks,
Neil