Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758258AbcK3QV1 (ORCPT ); Wed, 30 Nov 2016 11:21:27 -0500 Received: from mail-pg0-f54.google.com ([74.125.83.54]:33258 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754505AbcK3QVV (ORCPT ); Wed, 30 Nov 2016 11:21:21 -0500 From: Kevin Hilman To: Neil Armstrong Cc: Laurent Pinchart , airlied@linux.ie, carlo@caione.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, victor.wan@amlogic.com, jerry.cao@amlogic.com, Xing.Xu@amlogic.com, devicetree@vger.kernel.org, daniel@ffwll.ch Subject: Re: [PATCH v2 3/4] dt-bindings: display: add Amlogic Meson DRM Bindings Organization: BayLibre References: <1480520625-13269-1-git-send-email-narmstrong@baylibre.com> <1480520625-13269-4-git-send-email-narmstrong@baylibre.com> <2734274.BAOZxRirYz@avalon> <2e1b16c6-eec5-8cf3-5795-d6de02f36570@baylibre.com> Date: Wed, 30 Nov 2016 08:21:18 -0800 In-Reply-To: <2e1b16c6-eec5-8cf3-5795-d6de02f36570@baylibre.com> (Neil Armstrong's message of "Wed, 30 Nov 2016 17:00:59 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 23 Neil Armstrong writes: > Hi Laurent, > On 11/30/2016 04:58 PM, Laurent Pinchart wrote: >> Hi Neil, >> >> On Wednesday 30 Nov 2016 16:43:44 Neil Armstrong wrote: >>> Signed-off-by: Neil Armstrong >>> --- >>> .../bindings/display/meson/meson-drm.txt | 101 ++++++++++++++++++ >> >> I forgot to mention that the file should not be named meson-drm.txt as DRM is >> a Linux-specific concept. You can name it meson.txt, but a better option would >> be amlogic,meson.txt. By the way does it really need a subdirectory ? > > I took example of the sun4i layout the naming, and no it does not need a subdirector.. > > I will move it to amlogic,meson.txt, seems far better. > To me, amlogic,meson is redundant. Probably should be amlogic,vpu.txt? Kevin