Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758278AbcK3QWP (ORCPT ); Wed, 30 Nov 2016 11:22:15 -0500 Received: from mail-wj0-f182.google.com ([209.85.210.182]:32870 "EHLO mail-wj0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758260AbcK3QWI (ORCPT ); Wed, 30 Nov 2016 11:22:08 -0500 Subject: Re: [PATCH v2 3/4] dt-bindings: display: add Amlogic Meson DRM Bindings To: Kevin Hilman References: <1480520625-13269-1-git-send-email-narmstrong@baylibre.com> <1480520625-13269-4-git-send-email-narmstrong@baylibre.com> <2734274.BAOZxRirYz@avalon> <2e1b16c6-eec5-8cf3-5795-d6de02f36570@baylibre.com> Cc: Laurent Pinchart , airlied@linux.ie, carlo@caione.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, victor.wan@amlogic.com, jerry.cao@amlogic.com, Xing.Xu@amlogic.com, devicetree@vger.kernel.org, daniel@ffwll.ch From: Neil Armstrong Organization: Baylibre Message-ID: <6d0450dd-eb7c-a422-ec97-376c1f5fb6c6@baylibre.com> Date: Wed, 30 Nov 2016 17:22:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 927 Lines: 30 On 11/30/2016 05:21 PM, Kevin Hilman wrote: > Neil Armstrong writes: > >> Hi Laurent, >> On 11/30/2016 04:58 PM, Laurent Pinchart wrote: >>> Hi Neil, >>> >>> On Wednesday 30 Nov 2016 16:43:44 Neil Armstrong wrote: >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> .../bindings/display/meson/meson-drm.txt | 101 ++++++++++++++++++ >>> >>> I forgot to mention that the file should not be named meson-drm.txt as DRM is >>> a Linux-specific concept. You can name it meson.txt, but a better option would >>> be amlogic,meson.txt. By the way does it really need a subdirectory ? >> >> I took example of the sun4i layout the naming, and no it does not need a subdirector.. >> >> I will move it to amlogic,meson.txt, seems far better. >> > > To me, amlogic,meson is redundant. Probably should be amlogic,vpu.txt? > > Kevin > Yes, seems more coherent. Thanks, Neil