Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758383AbcK3RJp (ORCPT ); Wed, 30 Nov 2016 12:09:45 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:42389 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754374AbcK3RJg (ORCPT ); Wed, 30 Nov 2016 12:09:36 -0500 Subject: Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP To: Murali Karicheri , Santosh Shilimkar , Santosh Shilimkar References: <20161130165351.1154-1-grygorii.strashko@ti.com> CC: Sekhar Nori , , , Arnd Bergmann From: Grygorii Strashko Message-ID: Date: Wed, 30 Nov 2016 11:09:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161130165351.1154-1-grygorii.strashko@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.83.173] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 31 + Santosh Shilimkar On 11/30/2016 10:53 AM, Grygorii Strashko wrote: > The irq_set_affinity_hint() will always fail when !SMP and > Networking will fail on Keystone 2 devices in this case. > Hence, fix by ignoring IRQ affinity settings when !SMP. > > Cc: Arnd Bergmann > Signed-off-by: Grygorii Strashko > --- > drivers/soc/ti/knav_qmss_queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c > index b73e353..eacad57 100644 > --- a/drivers/soc/ti/knav_qmss_queue.c > +++ b/drivers/soc/ti/knav_qmss_queue.c > @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct knav_device *kdev, > > range->num_irqs++; > > - if (oirq.args_count == 3) > + if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3) > range->irqs[i].cpu_map = > (oirq.args[2] & 0x0000ff00) >> 8; > } > -- regards, -grygorii