Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758480AbcK3RLe (ORCPT ); Wed, 30 Nov 2016 12:11:34 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:16248 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758399AbcK3RLV (ORCPT ); Wed, 30 Nov 2016 12:11:21 -0500 Subject: Re: [PATCH] soc: ti: qmss: fix the case when !SMP To: Santosh Shilimkar , Arnd Bergmann , References: <20161129221508.10551-1-grygorii.strashko@ti.com> <5501170.dgvo5UdPBX@wuerfel> <2531f769-dd28-dfbd-0ed7-b209ef6ae98d@oracle.com> CC: Murali Karicheri , Santosh Shilimkar , Sekhar Nori , From: Grygorii Strashko Message-ID: <0a2d9284-d1e3-c848-42a4-66b06babba80@ti.com> Date: Wed, 30 Nov 2016 11:10:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2531f769-dd28-dfbd-0ed7-b209ef6ae98d@oracle.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.83.173] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 31 Hi Santosh, On 11/30/2016 11:01 AM, Santosh Shilimkar wrote: > Hi Grygorii, > > On 11/30/2016 3:37 AM, Arnd Bergmann wrote: >> On Tuesday, November 29, 2016 4:15:08 PM CET Grygorii Strashko wrote: >>> range->num_irqs++; >>> >>> - if (oirq.args_count == 3) >>> + if (IS_ENABLED(SMP) && oirq.args_count == 3) >>> range->irqs[i].cpu_map = >>> (oirq.args[2] & 0x0000ff00) >> 8; >>> >> >> I think you mean CONFIG_SMP, not SMP. With the change above, the >> code will never be executed. >> > Is that the full patch ? Can you post updated patch wit above fixed > and copy me. I will pick it up. > I've sent v2. For some reason you e-email is not working - delivery failure ssantosh@kernel.org -- regards, -grygorii