Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758333AbcK3ROI (ORCPT ); Wed, 30 Nov 2016 12:14:08 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:28159 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbcK3ROB (ORCPT ); Wed, 30 Nov 2016 12:14:01 -0500 Subject: Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP To: Arnd Bergmann References: <20161130165351.1154-1-grygorii.strashko@ti.com> Cc: Grygorii Strashko , Murali Karicheri , Santosh Shilimkar , Sekhar Nori , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <92af0586-7deb-9e94-a0e7-377337ebfb9e@oracle.com> Date: Wed, 30 Nov 2016 09:13:44 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 37 Hi Anrd, Can you apply this to your non critical fixes queue ? On 11/30/2016 9:09 AM, Grygorii Strashko wrote: > + Santosh Shilimkar > > On 11/30/2016 10:53 AM, Grygorii Strashko wrote: >> The irq_set_affinity_hint() will always fail when !SMP and >> Networking will fail on Keystone 2 devices in this case. >> Hence, fix by ignoring IRQ affinity settings when !SMP. >> >> Cc: Arnd Bergmann >> Signed-off-by: Grygorii Strashko >> --- Acked-by: Santosh Shilimkar >> drivers/soc/ti/knav_qmss_queue.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/soc/ti/knav_qmss_queue.c >> b/drivers/soc/ti/knav_qmss_queue.c >> index b73e353..eacad57 100644 >> --- a/drivers/soc/ti/knav_qmss_queue.c >> +++ b/drivers/soc/ti/knav_qmss_queue.c >> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct >> knav_device *kdev, >> >> range->num_irqs++; >> >> - if (oirq.args_count == 3) >> + if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3) >> range->irqs[i].cpu_map = >> (oirq.args[2] & 0x0000ff00) >> 8; >> } >> >