Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758461AbcK3RPQ (ORCPT ); Wed, 30 Nov 2016 12:15:16 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:32628 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754329AbcK3RPK (ORCPT ); Wed, 30 Nov 2016 12:15:10 -0500 Subject: Re: [PATCH] soc: ti: qmss: fix the case when !SMP To: Grygorii Strashko , Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <20161129221508.10551-1-grygorii.strashko@ti.com> <5501170.dgvo5UdPBX@wuerfel> <2531f769-dd28-dfbd-0ed7-b209ef6ae98d@oracle.com> <0a2d9284-d1e3-c848-42a4-66b06babba80@ti.com> Cc: Murali Karicheri , Santosh Shilimkar , Sekhar Nori , linux-kernel@vger.kernel.org From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: Date: Wed, 30 Nov 2016 09:14:52 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <0a2d9284-d1e3-c848-42a4-66b06babba80@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 955 Lines: 31 On 11/30/2016 9:10 AM, Grygorii Strashko wrote: > > Hi Santosh, > > On 11/30/2016 11:01 AM, Santosh Shilimkar wrote: >> Hi Grygorii, >> >> On 11/30/2016 3:37 AM, Arnd Bergmann wrote: >>> On Tuesday, November 29, 2016 4:15:08 PM CET Grygorii Strashko wrote: >>>> range->num_irqs++; >>>> >>>> - if (oirq.args_count == 3) >>>> + if (IS_ENABLED(SMP) && oirq.args_count == 3) >>>> range->irqs[i].cpu_map = >>>> (oirq.args[2] & 0x0000ff00) >> 8; >>>> >>> >>> I think you mean CONFIG_SMP, not SMP. With the change above, the >>> code will never be executed. >>> >> Is that the full patch ? Can you post updated patch wit above fixed >> and copy me. I will pick it up. >> > > I've sent v2. > > For some reason you e-email is not working - delivery failure > ssantosh@kernel.org > Weird. I was getting all the emails. Thanks for bouncing the thread. I will check.