Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757618AbcK3Sjx (ORCPT ); Wed, 30 Nov 2016 13:39:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42558 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbcK3Sjq (ORCPT ); Wed, 30 Nov 2016 13:39:46 -0500 Date: Wed, 30 Nov 2016 11:39:45 -0700 From: Alex Williamson To: Dan Carpenter Cc: Christophe JAILLET , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Kirti Wankhede Subject: Re: [PATCH] vfio: Fix handling of error returned by 'vfio_group_get_from_dev()' Message-ID: <20161130113945.2debb209@t450s.home> In-Reply-To: <20161130182707.GV6266@mwanda> References: <20161130070612.16073-1-christophe.jaillet@wanadoo.fr> <20161130093646.0c68f7be@t450s.home> <20161130182707.GV6266@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 30 Nov 2016 18:39:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 33 On Wed, 30 Nov 2016 21:27:07 +0300 Dan Carpenter wrote: > On Wed, Nov 30, 2016 at 09:36:46AM -0700, Alex Williamson wrote: > > On Wed, 30 Nov 2016 08:06:12 +0100 > > Christophe JAILLET wrote: > > > > > 'vfio_group_get_from_dev()' seems to return only NULL on error, not an error > > > pointer. > > > > > > Fixes: 2169037dc322 ("vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops") > > > Fixes: c086de818dd8 ("vfio iommu: Add blocking notifier to notify DMA_UNMAP") > > > > > > Signed-off-by: Christophe JAILLET > > > --- > > > > Dan Carpenter proposed a nearly identical patch: > > > > http://www.spinics.net/lists/kvm/msg141468.html > > > > The difference is you return -ENODEV while Dan returns -EINVAL. I tend > > to prefer -ENODEV to distinguish this error case versus validation of > > the other parameters. This patch also identifies both commits > > introducing these, so I'm inclined to take this one rather than Dan's > > version. Dan & Kirti, I welcome any credits you'd like to apply to > > this patch for identifying and reviewing the same issue. Thanks, > > > > Could I get a Reported-by? Sure thing, thanks, Alex