Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758149AbcK3SkS (ORCPT ); Wed, 30 Nov 2016 13:40:18 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:33871 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757710AbcK3SkJ (ORCPT ); Wed, 30 Nov 2016 13:40:09 -0500 MIME-Version: 1.0 In-Reply-To: <20161201051852.28dc335f@roar.ozlabs.ibm.com> References: <20161129131922.GA31466@angband.pl> <20161129135118.24696-1-kilobyte@angband.pl> <30bb2db4-47bd-0c35-8328-ef032b551f06@suse.com> <20161129195721.GI2697@decadent.org.uk> <20161201051852.28dc335f@roar.ozlabs.ibm.com> From: Linus Torvalds Date: Wed, 30 Nov 2016 10:40:02 -0800 X-Google-Sender-Auth: 7g_zlwb9hXC9w7EoShADc8P34Sw Message-ID: Subject: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm To: Nicholas Piggin Cc: Ben Hutchings , Michal Marek , Adam Borowski , Greg Kroah-Hartman , Linux Kbuild mailing list , Debian kernel maintainers , "linux-arch@vger.kernel.org" , Arnd Bergmann , Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1112 Lines: 25 On Wed, Nov 30, 2016 at 10:18 AM, Nicholas Piggin wrote: > > Here's an initial rough hack at removing modversions. It gives an idea > of the complexity we're carrying for this feature (keeping in mind most > of the lines removed are generated parser). You definitely don't have to try to convince me. We've had many issues with modversions over the years. This was just the "last drop" as far as I'm concerned, we've had random odd crc generation failures due to some build races too. > In its place I just added a simple config option to override vermagic > so distros can manage it entirely themselves. So at least Fedora doesn't even enable CONFIG_MODVERSIONS as-is. I'm _hoping_ it's just Debian that wants this, and we'd need to get some input from the Debian people whether that "control vermagic" is sufficient? I suspect it isn't, but I can't come up with any simple alternate model either.. I'm also somewhat surprised that it's Debian that has this problem, considering how Debian is usually the distro that is _least_ receptive to various non-free binaries. Linus