Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758695AbcK3SlE (ORCPT ); Wed, 30 Nov 2016 13:41:04 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:58849 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757704AbcK3Sky (ORCPT ); Wed, 30 Nov 2016 13:40:54 -0500 X-IronPort-AV: E=Sophos;i="5.31,574,1473145200"; d="scan'208";a="243969581" X-IronPort-AV: E=McAfee;i="5700,7163,8365"; a="822436630" X-Amp-Result: CLEAN From: "Valo, Kalle" To: Bjorn Andersson CC: "k.eugene.e@gmail.com" , Andy Gross , "wcn36xx@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Subject: Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Thread-Topic: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Thread-Index: AQHSSzk9Z7WROyIZuEi+FpgsyWUHWg== Date: Wed, 30 Nov 2016 18:40:36 +0000 Message-ID: <878ts0u7z3.fsf@kamboji.qca.qualcomm.com> References: <1479190014-11297-1-git-send-email-bjorn.andersson@linaro.org> <20161118183541.GI28340@tuxbot> <877f7vimyg.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <877f7vimyg.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Tue, 22 Nov 2016 14:55:04 +0000") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-Type: text/plain; charset="us-ascii" Content-ID: <61E5DD4E9277F144B083C9269603481A@qualcomm.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAUIf7va011295 Content-Length: 1934 Lines: 50 "Valo, Kalle" writes: > Bjorn Andersson writes: > >> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: >> >>> Bjorn Andersson wrote: >>> > The correct include file for getting errno constants and ERR_PTR() is >>> > linux/err.h, rather than linux/errno.h, so fix the include. >>> > >>> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") >>> > Acked-by: Andy Gross >>> > Signed-off-by: Bjorn Andersson >>> >>> For some reason this fails to compile now. Can you take a look, please? >>> >>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined! >>> make[1]: *** [__modpost] Error 1 >>> make: *** [modules] Error 2 >>> >>> 5 patches set to Changes Requested. >>> >>> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() >>> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client >> >> This patch was updated with the necessary depends in Kconfig to catch >> this exact issue and when I pull in your .config (which has QCOM_SMD=n, >> QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine. >> >> I've tested the various combinations and it seems to work fine. Do you >> have any other patches in your tree? > > This was with the pending branch of my ath.git tree. There are other > wireless patches (ath10k etc) but I would guess they don't affect here. > >> Any stale objects? > > Not sure what you mean with this question, but I didn't run 'make clean' > if that's what you are asking. > >> Would you mind retesting this, before I invest more time in trying to >> reproduce the issue you're seeing? > > Sure, I'll take a look but that might take few days. I didn't find enough time to look at this in detail. I applied this to my ath.git pending branch, let's see what the kbuild bot finds. -- Kalle Valo