Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757666AbcK3T7r (ORCPT ); Wed, 30 Nov 2016 14:59:47 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41366 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbcK3T7i (ORCPT ); Wed, 30 Nov 2016 14:59:38 -0500 Date: Wed, 30 Nov 2016 14:59:36 -0500 (EST) Message-Id: <20161130.145936.1357519815495012632.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, mugunthanvnm@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, ivan.khoronzhuk@linaro.org, d-gerlach@ti.com Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during resume From: David Miller In-Reply-To: <20161129222703.10908-1-grygorii.strashko@ti.com> References: <20161129222703.10908-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Nov 2016 11:00:14 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 19 From: Grygorii Strashko Date: Tue, 29 Nov 2016 16:27:03 -0600 > netif_set_real_num_tx/rx_queues() are required to be called with rtnl_lock > taken, otherwise ASSERT_RTNL() warning will be triggered - which happens > now during System resume from suspend: > cpsw_resume() > |- cpsw_ndo_open() > |- netif_set_real_num_tx/rx_queues() > |- ASSERT_RTNL(); > > Hence, fix it by surrounding cpsw_ndo_open() by rtnl_lock/unlock() calls. > > Cc: Dave Gerlach > Cc: Ivan Khoronzhuk > Fixes: commit e05107e6b747 ("net: ethernet: ti: cpsw: add multi queue support") > Signed-off-by: Grygorii Strashko Applied.