Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758928AbcK3UxO (ORCPT ); Wed, 30 Nov 2016 15:53:14 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:40117 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755273AbcK3Uwf (ORCPT ); Wed, 30 Nov 2016 15:52:35 -0500 Date: Wed, 30 Nov 2016 21:52:33 +0100 From: Maxime Ripard To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Jean-Francois Moine , Icenowy Zheng , devicetree@vger.kernel.org, wens@csie.org, linux-kernel , linux-sunxi , linux-arm-kernel@lists.infradead.org Subject: Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3 Message-ID: <20161130205233.mwfqlfuqg4cefink@lukather> References: <20161130220324.3Kg4VPEw@smtp1m.mail.yandex.net> <2717236.xBNAaGdqdc@jernej-laptop> <20161130203724.a390595df0199ed19069f91d@free.fr> <185067972.ij8nq5Ea6J@jernej-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5bpbmitmjaneujbj" Content-Disposition: inline In-Reply-To: <185067972.ij8nq5Ea6J@jernej-laptop> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2368 Lines: 67 --5bpbmitmjaneujbj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 30, 2016 at 09:41:26PM +0100, Jernej =C5=A0krabec wrote: > > > > > The only > > > > > code left from you is for DE2. HDMI stuff is basically copied from > > > > > Rockhip > > > > > driver (including EDID reading), TCON code is now reverted to the= same > > > > > as > > > > > it is in sunxi_display.c. I think it is worth to take a look at E= DID > > > > > code > > > > > and compare it. > > > >=20 > > > > So is the TCON of DE 2.0 identical to the original TCON? > > > >=20 > > > > If so, we should reuse sun4i-tcon ... > > >=20 > > > Well, TCON is splitted in two parts (two base addresses), one for HDM= I and > > > one for TV. However, register offsets are same as before, so I guess > > > driver reusage make sense. I think that there are few additional > > > registers, but they can be ignored for simplefb. > >=20 > > The TCON1 of the H3 is not usable (no ckock). Analog TV has its own > > clock and I/O area. > >=20 >=20 > True, H3 user manual can be misleading sometimes. But this doesn't change= the=20 > fact that TCON0 has same register offsets with same meaning. Then yes, we should definitely share the drivers too. So, in the end, the only thing that is actually new is the display-engine? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --5bpbmitmjaneujbj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYPzwNAAoJEBx+YmzsjxAgwZMQALyX0ij4pqSbcHMFhz+3Ttsk AogNkLk6K3X3FIuV/AxnjX0egZ6Vb16HLLzlije2UvvNXHqbAiLUJheRDNRc0DkQ lggQv12d8NTvglnu5KRh3xdsdTh22hoISfxk9VovAkFn4pT7O/Tix0tYGA8r2zIr oOAShtS6HlU3NFsnHyNbggWb4Uh59QZmPPZekE10u+FaGhTm69R38lc6Gj6BcBMc G26bKynjjeke8mL984X0sRN5moe4l4ANhUPdFxaJvl0q0ziLZDEJTCYB/pD94dPP OwfIN9FmfZPsFsagi98rMkC0UWvE5gNasAc/+WR3F5+V9udzEUHaoxTMUIbw1Ryl EBdCoFNOnQ0+VCeoY4AfhXSyuhODEbVHJRHPwpQ9oAfEWejhcm4b6ECV+edysFu0 LD8lCY9mfF9KD2n8lA2493mcKI/q++WGFxTLZ0I4Cv6WPUjElkn2mXhjXliYeT4z HoSbr38VmWjkC9nU/aKaPykFsYG+yjiAlzVgQYNIYkMDZ2gUezDOcCWZ3iEPRBsD 7EnC4BkZSI89EVtrfJgwm1K1w2i5enhnTOfzCmc9xhUwq+FNJ7XXralnqpCJhivC f1p6Gl5VyNWMiZXo2wi/E65Pm9I7JEL8mMFkBC0J9lKA/cgpj6QiNik4K5OOJDhH e4Tpla+YGtIQhJApLchZ =InLG -----END PGP SIGNATURE----- --5bpbmitmjaneujbj--