Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757385AbcK3V3D (ORCPT ); Wed, 30 Nov 2016 16:29:03 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50004 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753594AbcK3V3B (ORCPT ); Wed, 30 Nov 2016 16:29:01 -0500 Subject: Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI To: Benjamin Herrenschmidt , linux-scsi@vger.kernel.org References: <1479947042.10230.88.camel@kernel.crashing.org> Cc: "linux-kernel@vger.kernel.org" , linuxppc dev list From: Brian King Date: Wed, 30 Nov 2016 15:28:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479947042.10230.88.camel@kernel.crashing.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16113021-0012-0000-0000-000011468448 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006170; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000193; SDB=6.00787522; UDB=6.00380952; IPR=6.00565203; BA=6.00004933; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013494; XFM=3.00000011; UTC=2016-11-30 21:28:58 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16113021-0013-0000-0000-0000479FB0A0 Message-Id: <683a1049-2ff3-2777-b908-062212008ae4@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-30_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611300345 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 33 Looks good. Thanks! Here is an updated version that should apply cleanly on top of scsi-next. 8< From: Benjamin Herrenschmidt LSIs must be ack'ed with an MMIO otherwise they remain asserted forever. This is controlled by the "clear_isr" flag. While we set that flag properly when deciding initially whether to use LSIs or MSIs, we fail to set it if we first chose MSIs, the test fails, then fallback to LSIs. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Brian King --- drivers/scsi/ipr.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/scsi/ipr.c~ipr_misx_fail_intx_clear_isr drivers/scsi/ipr.c --- scsi/drivers/scsi/ipr.c~ipr_misx_fail_intx_clear_isr 2016-11-29 20:56:27.902534325 -0600 +++ scsi-bjking1/drivers/scsi/ipr.c 2016-11-29 20:56:50.645538533 -0600 @@ -10157,6 +10157,7 @@ static int ipr_probe_ioa(struct pci_dev pci_free_irq_vectors(pdev); ioa_cfg->nvectors = 1; + ioa_cfg->clear_isr = 1; break; default: goto out_msi_disable; _