Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758843AbcK3Vfi (ORCPT ); Wed, 30 Nov 2016 16:35:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755249AbcK3Vfg (ORCPT ); Wed, 30 Nov 2016 16:35:36 -0500 Subject: Re: Odd build breakage in 4.9-rc7 To: Paul Bolle References: <20161130172435.GG8563@redhat.com> <1480539150.27962.11.camel@tiscali.nl> <942ca543-de49-abda-7e3b-a8a31c0c2c88@redhat.com> Cc: Tony Luck , Linus Torvalds , Prarit Bhargava , linux-kernel@vger.kernel.org From: Jarod Wilson Message-ID: <222b47f2-55e0-3410-c87d-183ca5e2a0fe@redhat.com> Date: Wed, 30 Nov 2016 16:35:34 -0500 User-Agent: Mutt/1.5.21 (2010-09-15) MIME-Version: 1.0 In-Reply-To: <942ca543-de49-abda-7e3b-a8a31c0c2c88@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 30 Nov 2016 21:35:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 39 On 2016-11-30 4:07 PM, Jarod Wilson wrote: > On 2016-11-30 3:52 PM, Paul Bolle wrote: >> On Wed, 2016-11-30 at 12:24 -0500, Jarod Wilson wrote: >>> Up second, once we're past the above, building modules goes splat: >>> >>> ----8<---- >>> $ make -s ARCH=x86_64 V=1 -j8 modules >>> ... >>> ERROR: "module_put" [virt/lib/irqbypass.ko] undefined! >>> ERROR: "mutex_unlock" [virt/lib/irqbypass.ko] undefined! >>> ERROR: "mutex_lock" [virt/lib/irqbypass.ko] undefined! >>> ... >>> ----8<---- >>> >>> There are similar ERROR lines to the tune of 145k lines of output, >>> basically for every single module and symbol in the build. This breakage >>> was bisected to commit cd3caefb4663e3811d37cc2afad3cce642d60061, which >>> looks fairly innocuous, but when reverted, builds work fine again. >> >> I ran into a modules build printing over 100K ERROR lines a month ago: >> >> https://lkml.kernel.org/r/<1478165881-9263-1-git-send-email-pebolle@tiscali.nl> >> >> >> That had to do with setting TRIM_UNUSED_KSYMS and so unsetting >> UNUSED_SYMBOLS, >> as far as I could tell. Did you perhaps also have UNUSED_SYMBOLS unset >> when >> your modules build when splat? > > I did indeed have CONFIG_TRIM_UNUSED_KSYMS=y and CONFIG_UNUSED_SYMBOLS > unset. Just to confirm, with CONFIG_TRIM_UNUSED_KSYMS unset, the build behaves normally, no ERROR spew. -- Jarod Wilson jarod@redhat.com