Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755056AbcK3WvE (ORCPT ); Wed, 30 Nov 2016 17:51:04 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33036 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbcK3WvD (ORCPT ); Wed, 30 Nov 2016 17:51:03 -0500 From: Stafford Horne X-Google-Original-From: Stafford Horne Date: Thu, 1 Dec 2016 07:50:59 +0900 (JST) To: Randy Dunlap cc: LKML , kbuild test robot , Chen Gang , Jonas Bonn Subject: Re: [PATCH] openrisc: prevent VGA console, fix builds In-Reply-To: <876c2aef-f3be-e7d8-9586-c5192651fb3a@infradead.org> Message-ID: References: <876c2aef-f3be-e7d8-9586-c5192651fb3a@infradead.org> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 45 On Sun, 20 Nov 2016, Randy Dunlap wrote: > From: Randy Dunlap > > OpenRISC does not support VGA console, so prevent that kconfig symbol > from being enabled for OpenRISC, thus fixing these build errors: > > drivers/built-in.o: In function `vgacon_save_screen': > vgacon.c:(.text+0x20e0): undefined reference to `screen_info' > vgacon.c:(.text+0x20e8): undefined reference to `screen_info' > drivers/built-in.o: In function `vgacon_init': > vgacon.c:(.text+0x284c): undefined reference to `screen_info' > vgacon.c:(.text+0x2850): undefined reference to `screen_info' > drivers/built-in.o: In function `vgacon_startup': > vgacon.c:(.text+0x28d8): undefined reference to `screen_info' > drivers/built-in.o:vgacon.c:(.text+0x28f0): more undefined references to `screen_info' follow > > Signed-off-by: Randy Dunlap > Reported-by: kbuild test robot > Cc: Chen Gang > Cc: Jonas Bonn > --- > drivers/video/console/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Not tested. Can the robot please build-test this patch? Thanks. > > --- lnx-49-rc5.orig/drivers/video/console/Kconfig > +++ lnx-49-rc5/drivers/video/console/Kconfig > @@ -9,7 +9,7 @@ config VGA_CONSOLE > depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && \ > !SUPERH && !BLACKFIN && !AVR32 && !MN10300 && !CRIS && \ > (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \ > - !ARM64 && !ARC && !MICROBLAZE > + !ARM64 && !ARC && !MICROBLAZE && !OPENRISC > default y > help > Saying Y here will allow you to use Linux in text mode through a > Hello, I have pulled this.