Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758069AbcK3X0g (ORCPT ); Wed, 30 Nov 2016 18:26:36 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:35680 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcK3X0f (ORCPT ); Wed, 30 Nov 2016 18:26:35 -0500 Date: Thu, 1 Dec 2016 00:26:33 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op Message-ID: <20161130232633.GS21645@lunn.ch> References: <20161130225930.25510-1-vivien.didelot@savoirfairelinux.com> <20161130225930.25510-4-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161130225930.25510-4-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 797 Lines: 23 > diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > index ab52c37..9e51405 100644 > --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > @@ -765,6 +765,9 @@ struct mv88e6xxx_ops { > int (*phy_write)(struct mv88e6xxx_chip *chip, int addr, int reg, > u16 val); > > + /* Switch Software Reset */ > + int (*reset)(struct mv88e6xxx_chip *chip); > + Hi Vivien In my huge patch series of 6390, i've been using a g1_ prefix for functionality which is in global 1, g2_ for global 2, etc. This has worked for everything so far with the exception of setting which reserved MAC addresses should be sent to the CPU. Most devices have it in g2, but 6390 has it in g1. Please could you add the prefix. Andrew