Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756658AbcK3XyO (ORCPT ); Wed, 30 Nov 2016 18:54:14 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:60086 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755549AbcK3XyL (ORCPT ); Wed, 30 Nov 2016 18:54:11 -0500 Message-ID: <1480550044.16599.79.camel@decadent.org.uk> Subject: Re: [PATCH 3.12 122/127] drivers/net: Disable UFO through virtio From: Ben Hutchings To: Jiri Slaby , stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" Date: Wed, 30 Nov 2016 23:54:04 +0000 In-Reply-To: <290ca3467f0827248914b17ee721fe894e462bf8.1480062521.git.jslaby@suse.cz> References: <290ca3467f0827248914b17ee721fe894e462bf8.1480062521.git.jslaby@suse.cz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Iby8Uh/wFe400r73nPIk" X-Mailer: Evolution 3.22.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2670 Lines: 72 --=-Iby8Uh/wFe400r73nPIk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-11-25 at 09:30 +0100, Jiri Slaby wrote: > From: Ben Hutchings >=20 > 3.12-stable review patch.=C2=A0=C2=A0If anyone has any objections, please= let me know. This was reverted upstream (and in the only stable branch it was applied to). 3.12 already has the compatible fix (commit 30ab1cf8b31d). Ben. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 upstream. >=20 > IPv6 does not allow fragmentation by routers, so there is no > fragmentation ID in the fixed header.=C2=A0=C2=A0UFO for IPv6 requires th= e ID to > be passed separately, but there is no provision for this in the virtio > net protocol. >=20 > Until recently our software implementation of UFO/IPv6 generated a new > ID, but this was a bug.=C2=A0=C2=A0Now we will use ID=3D0 for any UFO/IPv= 6 packet > passed through a tap, which is even worse. >=20 > Unfortunately there is no distinction between UFO/IPv4 and v6 > features, so disable UFO on taps and virtio_net completely until we > have a proper solution. >=20 > We cannot depend on VM managers respecting the tap feature flags, so > keep accepting UFO packets but log a warning the first time we do > this. >=20 > Signed-off-by: Ben Hutchings > Fixes: 916e4cf46d02 ("ipv6: reuse ip6_frag_id from ip6_ufo_append_data") > Signed-off-by: David S. Miller > Signed-off-by: Jiri Slaby [...] --=20 Ben Hutchings Beware of programmers who carry screwdrivers. - Leonard Brandwein --=-Iby8Uh/wFe400r73nPIk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlg/ZpwACgkQ57/I7JWG EQmtFA//URIAzTJ2JbI26XCEew1gLpqo1NBKmtKF5RDBDQLWh+Ts0C9H1PBFTwUt zn+8Wh26tEfXPpk9CMIEF8R4f0bg76636NWTvHLIEz8EUmKaj2Tjd816RcIglVX0 GuBoVMtIhMcfhegC/TkPtTkbSyuyfEZxVVYDUTDZ/yEpyYKN2WjR7/z3fEBC41Sn 8/pneHFYZJVJ1JoQqCkr/o0CouvlTcttj2b0qKEov3mnKT/da2GRn9cxKdxX5fPl QzQVGXB4hqC80OZIru8/I54WqUnOtYjFRQ0RL9wLC/Rcgknv5+p/cfSRnpPv8Y2w DsMSB9DldSvFM+7vXDvQwItp3B1WQE8vP0iFP21KoAMia6p1GJGQsKrqVx1MqiM8 S3erMi8ERyu0kk0GewXmeC8cgIGCKGjl4IT6vtKPDOK3D6TE/cQKohb1BWl534EB oI3TaX5UZi0za01KDiRHspAYokMZxsHL9vs+oHEj34t4FggbCqyO2xMBFXoAWQro C2eXCRa/2uCTxjRgtKvxaXwhDeNwL4di5Ai1QX0OQnsEoP6LBKDQs2/iY81pUnoE QbK6XUqtmmNTt8Y2MlC18gtc7vfoc7bASkHQllyDa+2dirywCbx+b601XEV+HvOV 6lMjrZsp2lnkDI9FTZ2IJEHCrmqheZ3+nVyURXb+UV0nxSMb8Uo= =/gSb -----END PGP SIGNATURE----- --=-Iby8Uh/wFe400r73nPIk--