Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755602AbcLABfl (ORCPT ); Wed, 30 Nov 2016 20:35:41 -0500 Received: from mail-io0-f180.google.com ([209.85.223.180]:36052 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753242AbcLABfj (ORCPT ); Wed, 30 Nov 2016 20:35:39 -0500 MIME-Version: 1.0 In-Reply-To: <1479872809-11958-1-git-send-email-john.stultz@linaro.org> References: <1479872809-11958-1-git-send-email-john.stultz@linaro.org> From: John Stultz Date: Wed, 30 Nov 2016 17:35:38 -0800 Message-ID: Subject: Re: [RFC][PATCH 0/3] Try to connect hikey's usb phy to dwc2 driver To: lkml Cc: John Stultz , Wei Xu , Guodong Xu , Amit Pundir , Rob Herring , John Youn , Douglas Anderson , Chen Yu , Kishon Vijay Abraham I , Felipe Balbi , Greg Kroah-Hartman , Linux USB List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 33 On Tue, Nov 22, 2016 at 7:46 PM, John Stultz wrote: > After earlier attempts[1] at submitting somewhat hackish fixes > to the dwc2 driver, I realized the core issue seemed to be the > overly simplistic phy driver. > > I've connected the phy-hi6220-usb.c driver to extcon so it now > gets connection and disconnection signals on the usb gadget > cable. And I modified the driver so it registers a usb-phy and > calls usb_gadget_vbus_connect/disconnect() appropriately. > > Unfortunately this doesn't quite work with the dwc2 driver, > so I've hacked that driver to allow it to function. > > With these changes, while likely not correct, things function > well, and I was able to drop two of the hackish fixups from the > earlier set. I still needed one patch to keep the usb bus from > suspending while in gadget mode, so I've included that in this > series. > > [1]: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1272880.html > > Feedback and guidance would be greatly appreciated! > > > John Stultz (3): > phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver > HACK: dwc2: force dual use of uphy and phy > usb: dwc2: Avoid suspending if we're in gadget mode Curious if there was any feedback on this patchset or the general approach? thanks -john