Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756452AbcLAEsB (ORCPT ); Wed, 30 Nov 2016 23:48:01 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:38380 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbcLAEsA (ORCPT ); Wed, 30 Nov 2016 23:48:00 -0500 X-AuditID: cbfee61b-f796f6d000004092-c2-583fab7e1134 From: Shailendra Verma To: Mauro Carvalho Chehab , Laurent Pinchart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] V4l: omap3isp: Clean up file handle in open() and release(). Date: Thu, 01 Dec 2016 10:15:40 +0530 Message-id: <1480567540-13119-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t9jAd261fYRBhMn81h0TlzCbnF51xw2 i54NW1ktlm36w2Rxa95MNotF314xW/y9eInNgd1j56y77B6zO2ayemxa1cnm0bdlFaPH501y AaxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAO cA9W0rdLcMuYt+0/U8Ec9ooLz0+zNjA2sXUxcnJICJhIvF31mQXCFpO4cG89UJyLQ0hgKaPE 7+kTmSGcn4wSU2ZcYwKpYhMwlHjd95cJJCEi0M4k0XviBCNIgllARmLfxDagBAeHsICvROOx NJAwi4CqxM7V/5hBwrwCHhI7jrqDmBICChJzJtlMYORewMiwilEitSC5oDgpPdcoL7Vcrzgx t7g0L10vOT93EyM4QJ9J72A8vMv9EKMAB6MSD++Ou3YRQqyJZcWVuYcYJTiYlUR4z6+0jxDi TUmsrEotyo8vKs1JLT7EaAq0fiKzlGhyPjB68kriDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhP LEnNTk0tSC2C6WPi4JRqYGQ2LjHX3vojVGfZSenWaBWneQ3F4k2Z3KYv5b/6XGjv19/zbqbX pzllDEtuHXKx0rMw+3evl0Gg6lO53uJXwe6Lp99P5jdQdfC5f+WH9COD8L4Hj7vrxbcyfS6r 5Mq/cOXtbrZdu6ZlJe9azPxvmuOtnLsWmgZ8Gjuk35ROrlp6KvN2EU/9EiWW4oxEQy3mouJE ACcnaOxmAgAA X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 30 Both functions initialize the file handle with v4l2_fh_init() and thus need to call clean up with v4l2_fh_exit() as appropriate. Signed-off-by: Shailendra Verma --- drivers/media/platform/omap3isp/ispvideo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index 7354469..9f966e8 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file) done: if (ret < 0) { v4l2_fh_del(&handle->vfh); + v4l2_fh_exit(&handle->vfh); kfree(handle); } @@ -1373,6 +1374,7 @@ static int isp_video_release(struct file *file) /* Release the file handle. */ v4l2_fh_del(vfh); + v4l2_fh_exit(vfh); kfree(handle); file->private_data = NULL; -- 1.7.9.5