Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758583AbcLAEz1 (ORCPT ); Wed, 30 Nov 2016 23:55:27 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:48466 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755599AbcLAEzZ (ORCPT ); Wed, 30 Nov 2016 23:55:25 -0500 X-AuditID: cbfee61b-f796f6d000004092-a5-583fad3becf2 From: Shailendra Verma To: Mauro Carvalho Chehab , Laurent Pinchart , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] V4l: omap4iss: Clean up file handle in open() and release(). Date: Thu, 01 Dec 2016 10:22:52 +0530 Message-id: <1480567972-13510-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t9jQV3rtfYRBnMmSlrsOfOL3aJ58Xo2 i86JS9gtLu+aw2bRs2Erq8WyTX+YLG7Nm8lmsejbK2aLvxcvsTlwetzbd5jFY+esu+wesztm snpsWtXJ5rF/7hp2j74tqxg9Pm+SC2CPcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1UFLIS8xN tVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvGlN0nGAsWsFd8nrWYpYGxm62LkZNDQsBE YsnsycwQtpjEhXvrgeJcHEICsxglHp9ZxALh/GSUaH+xhBWkik3AUOJ1318mkISIwDUmiROf +9lBEswCMhL7JrYxgdjCAr4SrS8+g61gEVCVuHllGQuIzSvgIdF26TXQOg6gdQoScybZTGDk XsDIsIpRIrUguaA4KT3XKC+1XK84Mbe4NC9dLzk/dxMjOJifSe9gPLzL/RCjAAejEg/vjrt2 EUKsiWXFlbmHGCU4mJVEeLXX2EcI8aYkVlalFuXHF5XmpBYfYjQF2j+RWUo0OR8YaXkl8YYm 5ibmxgYW5paWJkZK4ryNs5+FCwmkJ5akZqemFqQWwfQxcXBKNTDyV4noP7Hq6hfVfJX/eNGN i/+PHgzxb+ybyyPfnejvw+S+zSb6ZmBnx9QPc/V2hz6W9T/7+cfewxbrDmUbeanck3x9N0pe N/2lULNAS0LYdXanteUbFkpITJV5aHru8baWVdsqumS31S67xWrPflFFuNhjp6JRYGTuzJLL pfvN9/QYc5izlyuxFGckGmoxFxUnAgATMKtTfAIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 30 Both functions initialize the file handle with v4l2_fh_init() and thus need to call clean up with v4l2_fh_exit() as appropriate. Signed-off-by: Shailendra Verma --- drivers/staging/media/omap4iss/iss_video.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index c16927a..077c9f8 100644 --- a/drivers/staging/media/omap4iss/iss_video.c +++ b/drivers/staging/media/omap4iss/iss_video.c @@ -1141,6 +1141,7 @@ static int iss_video_open(struct file *file) done: if (ret < 0) { v4l2_fh_del(&handle->vfh); + v4l2_fh_exit(&handle->vfh); kfree(handle); } @@ -1162,6 +1163,7 @@ static int iss_video_release(struct file *file) vb2_queue_release(&handle->queue); v4l2_fh_del(vfh); + v4l2_fh_exit(vfh); kfree(handle); file->private_data = NULL; -- 1.7.9.5