Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751147AbcLAFBX (ORCPT ); Thu, 1 Dec 2016 00:01:23 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:58354 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbcLAFBW (ORCPT ); Thu, 1 Dec 2016 00:01:22 -0500 X-AuditID: cbfee61a-f79916d0000062de-b0-583fac0a77ac From: Shailendra Verma To: Mauro Carvalho Chehab , Fabien Dessenne , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] Platform: Sti: Bdisp: Clean up file handle in open() error path. Date: Thu, 01 Dec 2016 10:17:51 +0530 Message-id: <1480567671-13239-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t9jAV2uNfYRBv1nJS2OrdvOaHF51xw2 i54NW1ktlm36w2Rxa95MNotF314xW/y9eInNgd1j56y77B6bVnWyefRtWcXo8fTHXmaPz5vk Alij3GwyUhNTUosUUvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc 4B6spG+X4Jbxuu82U8FEtoq3M+6yNzDOZ+1i5OSQEDCR+D/tBTOELSZx4d56ti5GLg4hgaWM EqtWdjJDOD8ZJZqOnmECqWITMJR43feXCSQhApKYORukhZODWUBGYt/ENrAiYYFgide3P4HZ LAKqEj+/vgRbxyvgIdHbd4mxi5EDaJ2CxJxJNhMYuRcwMqxilEgtSC4oTkrPNcxLLdcrTswt Ls1L10vOz93ECA7SZ1I7GA/ucj/EKMDBqMTDuyDOPkKINbGsuDL3EKMEB7OSCO+SVUAh3pTE yqrUovz4otKc1OJDjKZA+ycyS4km5wMjKK8k3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU 7NTUgtQimD4mDk6pBsYpS5cubuTTv3uX+9LMphO8y34V7egI3a9jGZb07anA/AU9+zaePR6Z tjbyta9P17QD/rGyPj9uXxdb3dA61f+r2Itg6Vr21/dvpcSynev9niOeb7X4ANOGN0WvNu44 t9DQ0Teh/MHsCvN68fqUWZy77VzFzboncjKoRLcEnd7FaJAc5SSyQ1SJpTgj0VCLuag4EQBT E3ojaAIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 24 The File handle is not yet added in the vdev list.So no need to call v4l2_fh_del(&ctx->fh)if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index 45f82b5..fbf302f 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -632,8 +632,8 @@ static int bdisp_open(struct file *file) error_ctrls: bdisp_ctrls_delete(ctx); -error_fh: v4l2_fh_del(&ctx->fh); +error_fh: v4l2_fh_exit(&ctx->fh); bdisp_hw_free_nodes(ctx); mem_ctx: -- 1.7.9.5