Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758493AbcLAFF2 (ORCPT ); Thu, 1 Dec 2016 00:05:28 -0500 Received: from mail5.windriver.com ([192.103.53.11]:58984 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbcLAFF1 (ORCPT ); Thu, 1 Dec 2016 00:05:27 -0500 Message-ID: <583FAF71.7070708@windriver.com> Date: Thu, 1 Dec 2016 13:04:49 +0800 From: yjin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Scott Wood , , , CC: , , , Subject: Re: [PATCH] powerpc: cputime: fix a compile warning References: <1479704219-21403-1-git-send-email-yanjiang.jin@windriver.com> <1480516844.21746.66.camel@buserror.net> In-Reply-To: <1480516844.21746.66.camel@buserror.net> Content-Type: multipart/mixed; boundary="------------090906000303010903050305" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3027 Lines: 96 --------------090906000303010903050305 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Hi Scott, Thanks for your reminder! I rephrased it as below: -#define cputime64_to_clock_t(ct) cputime_to_clock_t((cputime_t)(ct)) +#define cputime64_to_clock_t(ct) \ + (u64)(cputime_to_clock_t((cputime_t)(ct))) and rebuilt the kernel, no warnings found. New patch is attached, could you also help me to review it? Regards! Yanjiang On 2016年11月30日 22:40, Scott Wood wrote: > On Mon, 2016-11-21 at 12:56 +0800, yanjiang.jin@windriver.com wrote: >> From: Yanjiang Jin >> >> This patch is to avoid the below warning: >> >> kernel/sched/cpuacct.c:298:25: warning: >> format '%lld' expects argument of type 'long long int', >> but argument 4 has type 'long unsigned int' [-Wformat=] >> >> Signed-off-by: Yanjiang Jin >> --- >> arch/powerpc/include/asm/cputime.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/include/asm/cputime.h >> b/arch/powerpc/include/asm/cputime.h >> index 4f60db0..4423e97 100644 >> --- a/arch/powerpc/include/asm/cputime.h >> +++ b/arch/powerpc/include/asm/cputime.h >> @@ -228,7 +228,8 @@ static inline cputime_t clock_t_to_cputime(const >> unsigned long clk) >> return (__force cputime_t) ct; >> } >> >> -#define cputime64_to_clock_t(ct) cputime_to_clock_t((cputime_t)(ct)) >> +#define cputime64_to_clock_t(ct) \ >> + (__force u64)(cputime_to_clock_t((cputime_t)(ct))) > Why is __force needed? > > -Scott > --------------090906000303010903050305 Content-Type: text/x-patch; name="0001-powerpc-cputime-fix-a-compile-warning.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-powerpc-cputime-fix-a-compile-warning.patch" >From c32bc6ffe070e3d79a420e6adcbed5709079dc23 Mon Sep 17 00:00:00 2001 From: Yanjiang Jin Date: Sat, 19 Nov 2016 05:04:53 +0000 Subject: [PATCH] powerpc: cputime: fix a compile warning This patch is to avoid the below warning: kernel/sched/cpuacct.c:298:25: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'long unsigned int' [-Wformat=] Signed-off-by: Yanjiang Jin --- arch/powerpc/include/asm/cputime.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/cputime.h b/arch/powerpc/include/asm/cputime.h index 4f60db0..a25082b 100644 --- a/arch/powerpc/include/asm/cputime.h +++ b/arch/powerpc/include/asm/cputime.h @@ -228,7 +228,8 @@ static inline cputime_t clock_t_to_cputime(const unsigned long clk) return (__force cputime_t) ct; } -#define cputime64_to_clock_t(ct) cputime_to_clock_t((cputime_t)(ct)) +#define cputime64_to_clock_t(ct) \ + (u64)(cputime_to_clock_t((cputime_t)(ct))) /* * PPC64 uses PACA which is task independent for storing accounting data while -- 1.9.1 --------------090906000303010903050305--