Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758403AbcLAHlW (ORCPT ); Thu, 1 Dec 2016 02:41:22 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40898 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbcLAHlV (ORCPT ); Thu, 1 Dec 2016 02:41:21 -0500 X-ME-Sender: X-Sasl-enc: PYm0s+a/mzsRclwUfD+gTEglivhi3O9QZ1NYQ0dKZtxh 1480578079 Subject: Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize To: Jiada Wang , apape@de.adit-jv.com References: <20161130075923.15205-1-jiada_wang@mentor.com> <20161130075923.15205-2-jiada_wang@mentor.com> Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Mark_Craske@mentor.com From: Clemens Ladisch Message-ID: <1cb0aa49-62d5-b2ac-a473-bbce3f491d59@ladisch.de> Date: Thu, 1 Dec 2016 08:41:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161130075923.15205-2-jiada_wang@mentor.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 20 Jiada Wang wrote: > since commit 57e6dae1087bbaa6b33d3dd8a8e90b63888939a3 the expected packetsize is always limited to > nominal + 25%. It was discovered, that some devices Which devices? > have a much higher jitter in used packetsizes than 25% How high? (Please note that the USB specification restricts the jitter to at most one frame in consecutive packets.) > which would result in BABBLE condition and dropping of packets. > A better solution is so assume the jitter to be the nominal packetsize This solution is better for this one particular device, but how does it affect normal devices, or the Scarlett 2i4 on EHCI affected? Regards, Clemens