Subject: Re: [PATCH] ACPI: fix the process flow for 0 which return from
 acpi_register_gsi
To: <linux-kernel@vger.kernel.org>, <marc.zyngier@arm.com>,
        <linux-acpi@vger.kernel.org>, <robert.moore@intel.com>,
        <lenb@kernel.org>, <lv.zheng@intel.com>, <rafael.j.wysocki@intel.com>,
        <devel@acpica.org>, <mark.rutland@arm.com>, <robh+dt@kernel.org>,
        <jason@lakedaemon.net>
References: <1480578107-12512-1-git-send-email-majun258@huawei.com>
CC: <majun258@huawei.com>, <dingtianhong@huawei.com>,
        <guohanjun@huawei.com>
From: "majun (Euler7)" <majun258@huawei.com>
Message-ID: <583FD4BB.6060807@huawei.com>
Date: Thu, 1 Dec 2016 15:43:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <1480578107-12512-1-git-send-email-majun258@huawei.com>
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 846
Lines: 28

sorry, ignore this one..


?? 2016/12/1 15:41, Majun д??:
> From: MaJun <majun258@huawei.com>
> 
> The return value 0 from acpi_register_gsi() means irq mapping failed.
> So, we should process this case in else branch.
> 
> Signed-off-by: MaJun <majun258@huawei.com>
> ---
>  drivers/acpi/resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 56241eb..9918326 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -416,7 +416,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
>  
>  	res->flags = acpi_dev_irq_flags(triggering, polarity, shareable);
>  	irq = acpi_register_gsi(NULL, gsi, triggering, polarity);
> -	if (irq >= 0) {
> +	if (irq > 0) {
>  		res->start = irq;
>  		res->end = irq;
>  	} else {
>