Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758372AbcLAIUJ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Dec 2016 03:20:09 -0500
Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:56093
        "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1753150AbcLAIUH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Dec 2016 03:20:07 -0500
Date: Thu, 1 Dec 2016 06:19:59 -0200
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v2 1/2] docs-rst: move the rules for svg and graphviz to
 Makefile.sphinx
Message-ID: <20161201061959.73940e52@vento.lan>
In-Reply-To: <20161130180338.4a303400@lwn.net>
References: <4d2770fcc7a65dd1ad05387317bc1fb5c4b879be.1479756387.git.mchehab@s-opensource.com>
        <20161130180338.4a303400@lwn.net>
Organization: Samsung
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1673
Lines: 44

Em Wed, 30 Nov 2016 18:03:38 -0700
Jonathan Corbet <corbet@lwn.net> escreveu:

> On Mon, 21 Nov 2016 17:27:03 -0200
> Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
> 
> > Not only media documents may have images. So, move the
> > rules for building images from graphviz and from SVG to
> > the Documentation makefile.  
> 
> So I tried applying this one, but...
> 
> > LaTeX Warning: File `{media/typical_media_device}.*' not found on input line 22
> > 4.
> > 
> > ! Unable to load picture or PDF file 'media/typical_media_device.*'.
> > <to be read again> 
> >                    }
> > l.224 ...egraphics{{media/typical_media_device}.*}  
> 
> ...so something's not quite right there still.  Unapplied, for now.
>
> I'm thinking I'd like to button up docs-next for 4.10 pretty soon now;
> don't want end up with more patches than media, after all! :)  So maybe
> this one can be fixed at leisure and go in for 4.11.  I don't think we
> really need it urgently.

Weird, here it worked fine (I almost submitted it by mistake on
the patch series you merged yesterday). Maybe the DOTS or IMAGES
line may be missing some *.svg or *.dot file.

Yet, I agree that the best is not to merge it, specially since Markus 
has already a RFC for a Sphinx extension that would avoid the need of 
doing the conversion via Makefile. If it solves properly, we could merge
his patchset instead.

If something goes wrong with the extension, I'm keeping those two
patches, plus the one suggested by Daniel Vetter that uses find to
seek for the *.svg and *.dot file at the makefile on this branch:

	https://git.linuxtv.org/mchehab/experimental.git/log/?h=svg-images-v2

Thanks,
Mauro