Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757284AbcLAI4T (ORCPT ); Thu, 1 Dec 2016 03:56:19 -0500 Received: from mga05.intel.com ([192.55.52.43]:26595 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbcLAIzA (ORCPT ); Thu, 1 Dec 2016 03:55:00 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,723,1477983600"; d="asc'?scan'208";a="37569216" From: Felipe Balbi To: John Youn , Raviteja Garimella Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, BCM Kernel Feedback , linux-usb@vger.kernel.org, John Youn Subject: Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver In-Reply-To: <7de6b970-c88c-b277-eaae-d9c0067b590f@synopsys.com> References: <1480485910-7797-1-git-send-email-raviteja.garimella@broadcom.com> <1480485910-7797-3-git-send-email-raviteja.garimella@broadcom.com> <874m2pntdh.fsf@linux.intel.com> <87k2blm8yx.fsf@linux.intel.com> <7de6b970-c88c-b277-eaae-d9c0067b590f@synopsys.com> Date: Thu, 01 Dec 2016 10:53:58 +0200 Message-ID: <87eg1sm3mh.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2359 Lines: 69 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, John Youn writes: > On 11/30/2016 4:47 AM, Felipe Balbi wrote: >>=20 >> Hi, >>=20 >> Raviteja Garimella writes: >>> Hi Balbi, >>> >>> On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >>>> >>>> Hi, >>>> >>>> Raviteja Garimella writes: >>>>> This is driver for Synopsys Designware Cores USB Device >>>>> Controller (UDC) Subsystem with the AMBA Advanced High-Performance >>>>> Bus (AHB). This driver works with Synopsys UDC20 products. >>>>> >>>>> Signed-off-by: Raviteja Garimella >>>> >>>> use drivers/usb/dwc2 instead of duplicating it. >>> >>> The ones we have in drivers/usb/dwc2 is for Designware high speed OTG >>> controller IP. The one that I submitted for review is for USB Device >>> controller IP (UDC). The IPs are different. >>=20 >> I'll wait for John's confirmation that this really isn't compatible with >> dwc2. John? >>=20 > > Hi Felipe, > > This is our older UDC IP, not compatible with HSOTG. > > It is also no longer supported by Synopsys and considered EOL. Is it the same one used by amd5536udc.c? If it is, then it's much better to refactor that driver so it can be used as a library of sorts by PCI and non-PCI systems. We really don't want duplicated drivers upstream. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlg/5SYACgkQzL64meEa mQaWXw/+M9PdbI6FRerNsNVzk6w8aDfrV69iJy/TmUmZ6VlYnjsetGsEvbbYrR94 OdQvt+BvZ2TueQGj+0hLkItG2ESNePLVAIa6+JhgUrY2KBDmY+VTGFljjFOUWRF5 qqvdIHsHEP0+AHZxmYt6tEs9RYWDQaXMkrnZ8ZEj/9foEDl3ws++24agabsnThYO d+QW/OSdnqMphkhwAGQ7IGnvTia7+ipL/dVNSWmpu38vOYMbCWjUXYDkPwqeT+yz yP3mu1kcQ1B6fMUImdpCinpHrwIWFs1wiFqturXDR2jtB37iweav6uFXVmYCpZB0 Hhc253iIAVh21ps+YxquPY8b2kF7nfoFQKpQuqVuZKziaTfMN/Y2kV/bhDg/PyKe 8E+q1rvXy8G5qc3jx6s2al0/NPqwSh0P+y2rR3uyy/jBvCrCNCGJ2iKw9WXBiX7V yWYFM5VYA1FsLUqsmwFiC6shnNzRr0X9oCCn7td0X6HYQgftGYVbJeKhg8ySGvEu jcG+wM1MMwAT/dz8RD+m3xXwBllDQ7Pp4JZr8sGlUgxf/+WyF2apje2MWtISuxfe sRSad0msoMVAel7uZZghg8SfHorCJZ8Ab0/ea8eMytDEqOFARnLsbP6PnopVdeSm poSfRq+QOcLifWTFk2X+q88d01d2ug3kh00/50G2JQalt7gyGDI= =mIYw -----END PGP SIGNATURE----- --=-=-=--