Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756324AbcLAJcO (ORCPT ); Thu, 1 Dec 2016 04:32:14 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:46534 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754342AbcLAJcM (ORCPT ); Thu, 1 Dec 2016 04:32:12 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Thu, 1 Dec 2016 09:32:36 +0000 From: Charles Keepax To: Pan Bian CC: Michael Turquette , Stephen Boyd , , , Subject: Re: [PATCH 1/1] clk: clk-wm831x: fix a logic error Message-ID: <20161201093236.GJ1867@localhost.localdomain> References: <1480573545-18588-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1480573545-18588-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612010171 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 472 Lines: 15 On Thu, Dec 01, 2016 at 02:25:44PM +0800, Pan Bian wrote: > Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function > wm831x_clkout_is_prepared() returns "true" when it fails to read > CLOCK_CONTROL_1. "true" means the device is already prepared. So > return "true" on the read failure seems improper. > > Signed-off-by: Pan Bian > --- Looks good to me: Acked-by: Charles Keepax Thanks, Charles