Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757054AbcLAK20 (ORCPT ); Thu, 1 Dec 2016 05:28:26 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:40702 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755561AbcLAK2Z (ORCPT ); Thu, 1 Dec 2016 05:28:25 -0500 From: Laurent Pinchart To: Shailendra Verma Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , vidushi.koul@samsung.com Subject: Re: [PATCH] V4l: omap3isp: Clean up file handle in open() and release(). Date: Thu, 01 Dec 2016 12:28:39 +0200 Message-ID: <1835003.usQhLsQOpN@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1480567540-13119-1-git-send-email-shailendra.v@samsung.com> References: <1480567540-13119-1-git-send-email-shailendra.v@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 42 Hi Shailendra, Thank you for the patch. On Thursday 01 Dec 2016 10:15:40 Shailendra Verma wrote: > Both functions initialize the file handle with v4l2_fh_init() > and thus need to call clean up with v4l2_fh_exit() as appropriate. > > Signed-off-by: Shailendra Verma Reviewed-by: Laurent Pinchart and applied to my tree for v4.11. > --- > drivers/media/platform/omap3isp/ispvideo.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/omap3isp/ispvideo.c > b/drivers/media/platform/omap3isp/ispvideo.c index 7354469..9f966e8 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file) > done: > if (ret < 0) { > v4l2_fh_del(&handle->vfh); > + v4l2_fh_exit(&handle->vfh); > kfree(handle); > } > > @@ -1373,6 +1374,7 @@ static int isp_video_release(struct file *file) > > /* Release the file handle. */ > v4l2_fh_del(vfh); > + v4l2_fh_exit(vfh); > kfree(handle); > file->private_data = NULL; -- Regards, Laurent Pinchart