Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757306AbcLALWt (ORCPT ); Thu, 1 Dec 2016 06:22:49 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:10696 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbcLALWr (ORCPT ); Thu, 1 Dec 2016 06:22:47 -0500 Subject: Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status To: Alexandre Belloni , "Ludovic Desroches" , Vinod Koul References: <20161201104903.30019-1-alexandre.belloni@free-electrons.com> CC: , , From: Nicolas Ferre Organization: atmel Message-ID: Date: Thu, 1 Dec 2016 12:22:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161201104903.30019-1-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.145.133.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 39 Le 01/12/2016 ? 11:49, Alexandre Belloni a ?crit : > save_gs is supposed to save the channel status in order to be restored at > resume time but it is never updated and is always 0. Anyway, the channel > status is updated in the per channel loop later in the resume function. > > Signed-off-by: Alexandre Belloni Indeed, seems superfluous... Acked-by: Nicolas Ferre > --- > drivers/dma/at_xdmac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index b7d7f2d443a1..8c1abb794340 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -221,7 +221,6 @@ struct at_xdmac { > int irq; > struct clk *clk; > u32 save_gim; > - u32 save_gs; > struct dma_pool *at_xdmac_desc_pool; > struct at_xdmac_chan chan[0]; > }; > @@ -1896,7 +1895,6 @@ static int atmel_xdmac_resume(struct device *dev) > } > > at_xdmac_write(atxdmac, AT_XDMAC_GIE, atxdmac->save_gim); > - at_xdmac_write(atxdmac, AT_XDMAC_GE, atxdmac->save_gs); > list_for_each_entry_safe(chan, _chan, &atxdmac->dma.channels, device_node) { > atchan = to_at_xdmac_chan(chan); > at_xdmac_chan_write(atchan, AT_XDMAC_CC, atchan->save_cc); > -- Nicolas Ferre