Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758899AbcLANGF (ORCPT ); Thu, 1 Dec 2016 08:06:05 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:47783 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758787AbcLANGD (ORCPT ); Thu, 1 Dec 2016 08:06:03 -0500 Subject: Re: [PATCH 18/39] Annotate hardware config module parameters in drivers/net/can/ To: David Howells , linux-kernel@vger.kernel.org References: <148059537897.31612.9461043954611464597.stgit@warthog.procyon.org.uk> <148059552122.31612.3286291221641529296.stgit@warthog.procyon.org.uk> Cc: gnomes@lxorguk.ukuu.org.uk, minyard@acm.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Wolfgang Grandegger From: Marc Kleine-Budde Message-ID: Date: Thu, 1 Dec 2016 14:05:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <148059552122.31612.3286291221641529296.stgit@warthog.procyon.org.uk> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xwX8KKmvaVXvGewfsnJXe6XWTdWRdGWhJ" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3578 Lines: 91 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xwX8KKmvaVXvGewfsnJXe6XWTdWRdGWhJ Content-Type: multipart/mixed; boundary="pibw3MjHPXDFfDuEcqVPLluMWuU8NI0l0"; protected-headers="v1" From: Marc Kleine-Budde To: David Howells , linux-kernel@vger.kernel.org Cc: gnomes@lxorguk.ukuu.org.uk, minyard@acm.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Wolfgang Grandegger Message-ID: Subject: Re: [PATCH 18/39] Annotate hardware config module parameters in drivers/net/can/ References: <148059537897.31612.9461043954611464597.stgit@warthog.procyon.org.uk> <148059552122.31612.3286291221641529296.stgit@warthog.procyon.org.uk> In-Reply-To: <148059552122.31612.3286291221641529296.stgit@warthog.procyon.org.uk> --pibw3MjHPXDFfDuEcqVPLluMWuU8NI0l0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/01/2016 01:32 PM, David Howells wrote: > When the kernel is running in secure boot mode, we lock down the kernel= to > prevent userspace from modifying the running kernel image. Whilst this= > includes prohibiting access to things like /dev/mem, it must also preve= nt > access by means of configuring driver modules in such a way as to cause= a > device to access or modify the kernel image. >=20 > To this end, annotate module_param* statements that refer to hardware > configuration and indicate for future reference what type of parameter = they > specify. The parameter parser in the core sees this information and ca= n > skip such parameters with an error message if the kernel is locked down= =2E > The module initialisation then runs as normal, but just sees whatever t= he > default values for those parameters is. >=20 > Note that we do still need to do the module initialisation because some= > drivers have viable defaults set in case parameters aren't specified an= d > some drivers support automatic configuration (e.g. PNP or PCI) in addit= ion > to manually coded parameters. >=20 > This patch annotates drivers in drivers/net/can/. >=20 > Suggested-by: One Thousand Gnomes > Signed-off-by: David Howells > cc: Wolfgang Grandegger > cc: Marc Kleine-Budde > cc: linux-can@vger.kernel.org > cc: netdev@vger.kernel.org Acked-by: Marc Kleine-Budde regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --pibw3MjHPXDFfDuEcqVPLluMWuU8NI0l0-- --xwX8KKmvaVXvGewfsnJXe6XWTdWRdGWhJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEES2FAuYbJvAGobdVQPTuqJaypJWoFAlhAIAoACgkQPTuqJayp JWp1IAgAkADs01rvguaxMOp7okZBrkV5PWieww+Pc0u8sYWav9tPsPOnxnBbiQtE mznY8OW4pRfa8BHpjyltUtgTShn05ThtwU/E09g8EU4TaIghX146DwjKxbrbUlTR g6etsM6kV+UzF07AD22PzcMKGGj3gP6Ppgec7AJEdW4eY18CH8TJL5/5xf1hUjRN b0OKbhOdVLKw62JOaJ9dJ8eTRqv78EIpPYQQ6Il1ztGv1rY023zoz4LFam7be3vI 46U46sW7FHhIuy4RhTwa7WsAON073+etnIYBtAsaHCXM+GKFiGlcyaGsLGuQoV7r 1eFTh9mb0GQ7xObbESgIoBdqqsXDBQ== =3XdM -----END PGP SIGNATURE----- --xwX8KKmvaVXvGewfsnJXe6XWTdWRdGWhJ--