Subject: Re: [PATCH 1/1] block: mtip32xx: set error code on failure
To: Pan Bian <bianpan2016@163.com>,
        Asai Thambi SP <asamymuthupa@micron.com>,
        Selvan Mani <smani@micron.com>,
        Rajesh Kumar Sambandam <rsambandam@micron.com>,
        Vignesh Gunasekaran <vgunasekaran@micron.com>,
        Baoyou Xie <baoyou.xie@linaro.org>,
        Keith Busch <keith.busch@intel.com>,
        "Mike Christie" <mchristi@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>
References: <1480558246-19015-1-git-send-email-bianpan2016@163.com>
CC: <linux-kernel@vger.kernel.org>
From: Jens Axboe <axboe@fb.com>
Message-ID: <ae325a8d-cd91-b8d1-17f5-85613e9a4b10@fb.com>
Date: Thu, 1 Dec 2016 08:01:58 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1480558246-19015-1-git-send-email-bianpan2016@163.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2016 15:02:02.4347 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-01_12:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 585
Lines: 14

On 11/30/2016 07:10 PM, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188531. In function
> mtip_block_initialize(), variable rv takes the return value, and its
> value should be negative on errors. rv is initialized as 0 and is not
> reset when the call to ida_pre_get() fails. So 0 may be returned.
> The return value 0 indicates that there is no error, which may be
> inconsistent with the execution status. This patch fixes the bug by
> explicitly assigning -ENOMEM to rv on the branch that ida_pre_get()
> fails.

Thanks, applied for 4.10.

-- 
Jens Axboe