Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759925AbcLAPXJ (ORCPT ); Thu, 1 Dec 2016 10:23:09 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:48956 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1759232AbcLAPXH (ORCPT ); Thu, 1 Dec 2016 10:23:07 -0500 Date: Thu, 1 Dec 2016 10:16:24 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: csmanjuvijay@gmail.com cc: Greg Kroah-Hartman , , Subject: Re: [PATCH v3] USB: OHCI: ohci-pxa27x: remove useless functions In-Reply-To: <1480601088-23219-1-git-send-email-csmanjuvijay@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2642 Lines: 69 On Thu, 1 Dec 2016 csmanjuvijay@gmail.com wrote: > From: Manjunath Goudar > > The ohci_hcd_pxa27x_drv_probe function is not doing anything other > than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe > function is useless that is why removed ohci_hcd_pxa27x_drv_probe > function and renamed usb_hcd_pxa27x_probe function to > ohci_hcd_pxa27x_drv_probe for proper naming. > > The ohci_hcd_pxa27x_remove function is also not doing anything other than > calling usb_hcd_pxa27x_remove that is why removed ohci_hcd_pxa27x_remove > function and renamed usb_hcd_pxa27x_remove to ohci_hcd_pxa27x_remove for > proper naming. > > Signed-off-by: Manjunath Goudar > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > Changelog v1 -> v2: > Removed warnings and errors of checkpatch.pl script. > Replaced unuseful with useless in patch commit message for proper meaning. > Removed usb_disabled() from ohci_hcd_pxa27x_drv_probe function because it > is already existing in ohci_pxa27x_init function > > Changelog v2 -> v3: > Removed checkpatch.pl warnings and errors cleanup code which is not related > to this patch. > drivers/usb/host/ohci-pxa27x.c | 38 ++++++++++++-------------------------- > 1 file changed, 12 insertions(+), 26 deletions(-) Just one little thing... > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index a667cf2..1b6b46e 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -404,7 +404,7 @@ static int ohci_pxa_of_init(struct platform_device *pdev) > > > /** > - * usb_hcd_pxa27x_probe - initialize pxa27x-based HCDs > + * ohci_hcd_pxa27x_probe - initialize pxa27x-based HCDs > * Context: !in_interrupt() > * > * Allocates basic resources for this USB host controller, and > @@ -412,7 +412,7 @@ static int ohci_pxa_of_init(struct platform_device *pdev) > * through the hotplug entry's driver_data. > * > */ > -int usb_hcd_pxa27x_probe (const struct hc_driver *driver, struct platform_device *pdev) > +static int ohci_hcd_pxa27x_probe(struct platform_device *pdev) > { > int retval, irq; > struct usb_hcd *hcd; > @@ -423,6 +423,8 @@ int usb_hcd_pxa27x_probe (const struct hc_driver *driver, struct platform_device > struct clk *usb_clk; > unsigned int i; > > + pr_debug("In ohci_hcd_pxa27x_drv_probe"); > + Don't insert this pr_debug line. After fixing that up, you can add: Acked-by: Alan Stern Alan Stern