Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760371AbcLAPfx (ORCPT ); Thu, 1 Dec 2016 10:35:53 -0500 Received: from p3plsmtps2ded01.prod.phx3.secureserver.net ([208.109.80.58]:37062 "EHLO p3plsmtps2ded01.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759232AbcLAPeD (ORCPT ); Thu, 1 Dec 2016 10:34:03 -0500 x-originating-ip: 72.167.245.219 From: kys@exchange.microsoft.com To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com Cc: "K. Y. Srinivasan" Subject: [PATCH 06/15] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() Date: Thu, 1 Dec 2016 09:28:43 -0800 Message-Id: <1480613332-7788-6-git-send-email-kys@exchange.microsoft.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1480613332-7788-1-git-send-email-kys@exchange.microsoft.com> References: <1480613287-7748-1-git-send-email-kys@exchange.microsoft.com> <1480613332-7788-1-git-send-email-kys@exchange.microsoft.com> Reply-To: kys@microsoft.com X-CMAE-Envelope: MS4wfD/TdCNlhl9FzVBMa0Zwvv+cyoMbDmjFcFH4gYvt5ovg/QlG916+8bctCWDTE4j0BtRHCd1fJcKmGHwwSK/SJKepwwvcwSwDvn1r/XL2/oXZ3a/C3Yb2 Z6Zu+emdcoLKveNT5hPAet1QjLtUDEfedrmuDBSOaC0s0utGnqguap9WvHxR0grSbLQXJmf3QOfPliboZ33iMaRLGzZKZ7OVLd1QDH5sccA+2bDAgFvUSKiU QmL23L8fxDWDLx1CE7HmN2rtQ1GeOGuGPwwJmGCSb4UlNj1pcZwlmBywVCP3qMmvnWEipS12uUa3m4WLKpt7eMr0g+m6hyiTh8zYGf0y8hBLLqy/u3+k4pKo Kk2HFgN9pJj4erlwxQf1l1nTzijh8TLwgLg+vOnJfKTHtEyvvcOufijumM38QtezrL4m5WyrBb0WR0bqmAbqq1HKqBOoBQL3D7M6XaQBycJ/VFTOsZ8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 36 From: Vitaly Kuznetsov "kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus module is unloaded. BUG_ON() was introduced in commit 85d9aa705184 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as vmbus_free_channels() codepath was apparently forgotten. Fixes: 85d9aa705184 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index d83c1ac..e68f06c 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -390,6 +390,7 @@ void vmbus_free_channels(void) { struct vmbus_channel *channel, *tmp; + mutex_lock(&vmbus_connection.channel_mutex); list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list, listentry) { /* hv_process_channel_removal() needs this */ @@ -397,6 +398,7 @@ void vmbus_free_channels(void) vmbus_device_unregister(channel->device_obj); } + mutex_unlock(&vmbus_connection.channel_mutex); } /* -- 1.7.4.1