MIME-Version: 1.0
In-Reply-To: <20161201162039.602da20a@roar.ozlabs.ibm.com>
References: <CAB=NE6Whw=q-7waoqE7PmJZ+ZVGN9QqsKg26819gvStfPk_+8A@mail.gmail.com>
 <f9e3abc8-fc5f-df73-4ddf-6f7a7b4a9112@roeck-us.net> <20161130013349.GN1402@wotan.suse.de>
 <20161130140947.3ea27d9e@roar.ozlabs.ibm.com> <20161130173816.GP1402@wotan.suse.de>
 <20161201135146.295868f0@roar.ozlabs.ibm.com> <CAB=NE6URuz6rGa4jD9xQ4z4ZoJW6Rurk=xQAphoT-D5VWE-tow@mail.gmail.com>
 <20161201160430.6e95710a@roar.ozlabs.ibm.com> <20161201162039.602da20a@roar.ozlabs.ibm.com>
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
Date: Thu, 1 Dec 2016 08:34:56 -0800
Message-ID: <CAB=NE6XOw+b6GGT-a6D9Da1hQvKnnrUjbon+RqPD4JVpSN8QGg@mail.gmail.com>
Subject: Re: linker-tables v5 testing
To: Nicholas Piggin <npiggin@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Michael Matz <matz@suse.de>,
        Arnd Bergmann <arnd@arndb.de>, Josh Poimboeuf <jpoimboe@redhat.com>,
        Kees Cook <keescook@chromium.org>, Guenter Roeck <linux@roeck-us.net>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Fengguang Wu <fengguang.wu@intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Joerg Roedel <joro@8bytes.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1987
Lines: 45

On Wed, Nov 30, 2016 at 9:20 PM, Nicholas Piggin <npiggin@gmail.com> wrote:
> On Thu, 1 Dec 2016 16:04:30 +1100
> Nicholas Piggin <npiggin@gmail.com> wrote:
>
>> On Wed, 30 Nov 2016 19:15:27 -0800
>> "Luis R. Rodriguez" <mcgrof@kernel.org> wrote:
>>
>> > On Wed, Nov 30, 2016 at 6:51 PM, Nicholas Piggin <npiggin@gmail.com> wrote:
>> > > On Wed, 30 Nov 2016 18:38:16 +0100
>> > > "Luis R. Rodriguez" <mcgrof@kernel.org> wrote:
>> > >
>> > >> On Wed, Nov 30, 2016 at 02:09:47PM +1100, Nicholas Piggin wrote:
>>
>> > >> What is wrong with that ? Separating linker table and section ranges is
>> > >
>> > > It's not that you separate those, of course you need that. It's that
>> > > you also separate other sections from the input section descriptions:
>> > >
>> > > -               *(.text.hot .text .text.fixup .text.unlikely)           \
>> > > +               *(.text.hot .text)                                      \
>> > > +               *(SORT(.text.rng.*))                                    \
>> > > +               *(.text.fixup .text.unlikely)                           \
>
> Ahh, you're doing it to avoid clash with compiler generated sections.

Nope, its for two reasons:

1) To be able to construct arrays without modifying the linker script
we had to get crafty, and opted in for the trick of picking two
arbitrary delimiters for use of section start, and section end, namely
the tilde character ("~") and the empty string (""), and then stuffing
anything in between. For this to work properly we must SORT() these
specially crafted sections as well.

2) Because I don't want to regress .text if SORT()'ing it breaks
something. In theory it should not but I rather be careful.

> The usual way to cope with that seems to be to use two dots for your name.
> .text..rng.*

I have been wondering why people started doing that, it was not clear
nor documented anywhere. So no, it was not my original motivation, but
if it helps, it will be good to document this as well.

 Luis