Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757158AbcLARVS (ORCPT ); Thu, 1 Dec 2016 12:21:18 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:36591 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753657AbcLARVR (ORCPT ); Thu, 1 Dec 2016 12:21:17 -0500 Subject: Re: [PATCH] net: stmmac: enable tx queue 0 for gmac4 IPs synthesized with multiple TX queues To: David Miller , References: <1479998194-7113-1-git-send-email-niklass@axis.com> <20161128.112921.631621178188973017.davem@davemloft.net> CC: , , , From: Alexandre Torgue Message-ID: Date: Thu, 1 Dec 2016 18:21:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161128.112921.631621178188973017.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.129.7.138] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-01_14:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 28 Hi David and Niklas, On 11/28/2016 05:29 PM, David Miller wrote: > From: Niklas Cassel > Date: Thu, 24 Nov 2016 15:36:33 +0100 > >> From: Niklas Cassel >> >> The dwmac4 IP can synthesized with 1-8 number of tx queues. >> On an IP synthesized with DWC_EQOS_NUM_TXQ > 1, all txqueues are disabled >> by default. For these IPs, the bitfield TXQEN is R/W. >> >> Always enable tx queue 0. The write will have no effect on IPs synthesized >> with DWC_EQOS_NUM_TXQ == 1. >> >> The driver does still not utilize more than one tx queue in the IP. >> >> Signed-off-by: Niklas Cassel > > Alexandre, we are still waiting for your implicit/explicit ACK on this > change. Yes you could add my Acked-by but it is already merged. My fault. Sorry for my late answer :( > > Thank you. >