Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757754AbcLARXX (ORCPT ); Thu, 1 Dec 2016 12:23:23 -0500 Received: from mail-yw0-f196.google.com ([209.85.161.196]:33371 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbcLARXW (ORCPT ); Thu, 1 Dec 2016 12:23:22 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161128140134.25128-1-zajec5@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Thu, 1 Dec 2016 18:23:20 +0100 Message-ID: Subject: Re: [PATCH] ARM: BCM5301X: Enable UART by default for BCM4708(1) and BCM4709(4) To: Jon Mason Cc: Florian Fainelli , Rob Herring , Mark Rutland , Russell King , Hauke Mehrtens , BCM Kernel Feedback , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel , open list , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB1HNSrj016632 Content-Length: 3156 Lines: 60 On 1 December 2016 at 18:14, Jon Mason wrote: > On Mon, Nov 28, 2016 at 9:01 AM, Rafał Miłecki wrote: >> >> From: Rafał Miłecki >> >> Every device tested so far got UART0 (at 0x18000300) working as serial >> console. It's most likely part of reference design and all vendors use >> it that way. >> >> It seems to be easier to enable it by default and just disable it if we >> ever see a device with different hardware design. >> >> Signed-off-by: Rafał Miłecki >> --- >> arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts | 4 ---- >> arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts | 4 ---- >> arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts | 4 ---- >> arch/arm/boot/dts/bcm4708-netgear-r6250.dts | 4 ---- >> arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 4 ---- >> arch/arm/boot/dts/bcm4708.dtsi | 4 ++++ >> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 4 ---- >> arch/arm/boot/dts/bcm47081.dtsi | 4 ++++ >> arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 4 ---- >> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 4 ---- >> arch/arm/boot/dts/bcm4709-tplink-archer-c9-v1.dts | 4 ---- >> arch/arm/boot/dts/bcm4709.dtsi | 1 + >> arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 4 ---- >> arch/arm/boot/dts/bcm47094-luxul-xwr-3100.dts | 4 ---- >> arch/arm/boot/dts/bcm47094-netgear-r8500.dts | 4 ---- >> arch/arm/boot/dts/bcm47094.dtsi | 1 + > > > I think there are a few missing here. A quick grep shows > > $ grep -rI '#include "bcm470[89].dtsi"' arch/arm/boot/dts/*.dts > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4708-netgear-r6250.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts:#include "bcm4709.dtsi" > arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts:#include "bcm4709.dtsi" > arch/arm/boot/dts/bcm4709-netgear-r7000.dts:#include "bcm4709.dtsi" > arch/arm/boot/dts/bcm4709-netgear-r8000.dts:#include "bcm4709.dtsi" > arch/arm/boot/dts/bcm4709-tplink-archer-c9-v1.dts:#include "bcm4709.dtsi" > arch/arm/boot/dts/bcm94708.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm94709.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm953012er.dts:#include "bcm4708.dtsi" > arch/arm/boot/dts/bcm953012k.dts:#include "bcm4708.dtsi" > > I specifically care about the last 4 :) Actually the only missing ones are the last 4. Other ones (e.g. bcm4709-buffalo-wxr-1900dhp.dts) never got uart0 enabled so I just didn't need to modify these files. I'll send V2 updating last 4 ones as well. Thanks for catching this.