Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934145AbcLAUPj (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Dec 2016 15:15:39 -0500
Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:33583 "EHLO
        lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752365AbcLAUPh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Dec 2016 15:15:37 -0500
Message-ID: <1480623331.22912.3.camel@tiscali.nl>
Subject: Re: Odd build breakage in 4.9-rc7
From: Paul Bolle <pebolle@tiscali.nl>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Jarod Wilson <jarod@redhat.com>, Tony Luck <tony.luck@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org
Date: Thu, 01 Dec 2016 21:15:31 +0100
In-Reply-To: <alpine.LFD.2.20.1612011238480.1715@knanqh.ubzr>
References: <20161130172435.GG8563@redhat.com>
         <1480539150.27962.11.camel@tiscali.nl>
         <942ca543-de49-abda-7e3b-a8a31c0c2c88@redhat.com>
         <222b47f2-55e0-3410-c87d-183ca5e2a0fe@redhat.com>
         <1480542127.27962.17.camel@tiscali.nl>
         <1480543047.27962.23.camel@tiscali.nl>
         <4330d00e-ed4f-35fe-586e-f3d5dd6db875@redhat.com>
         <1480582887.27962.48.camel@tiscali.nl>
         <1480599966.19457.4.camel@tiscali.nl>
         <alpine.LFD.2.20.1612011238480.1715@knanqh.ubzr>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1358
Lines: 43

On Thu, 2016-12-01 at 12:42 -0500, Nicolas Pitre wrote:
> OK I understand what the problem is.  However most of those hunks below 
> are definitely wrong. ;-)

Probably. By now I've narrowed it down to just these two hunks:

diff --git a/scripts/Makefile b/scripts/Makefile
index 1d80897a9644..f23e5c4f2496 100644
--- a/scripts/Makefile
+++ b/scripts/Makefile
@@ -40,7 +40,9 @@ build_docproc: $(obj)/docproc
 build_check-lc_ctype: $(obj)/check-lc_ctype
 	@:
 
-subdir-$(CONFIG_MODVERSIONS) += genksyms
+ifeq ($(or $(CONFIG_MODVERSIONS),$(CONFIG_TRIM_UNUSED_KSYMS)),y)
+subdir-y                     += genksyms
+endif
 subdir-y                     += mod
 subdir-$(CONFIG_SECURITY_SELINUX) += selinux
 subdir-$(CONFIG_DTC)         += dtc
diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
index 8dc1918b6783..7525da1cc2f7 100755
--- a/scripts/adjust_autoksyms.sh
+++ b/scripts/adjust_autoksyms.sh
@@ -68,7 +68,7 @@ while read sym; do
 done >> "$new_ksyms_file"
 
 # Special case for modversions (see modpost.c)
-if [ -n "$CONFIG_MODVERSIONS" ]; then
+if [ -n "$CONFIG_MODVERSIONS" -o -n "$CONFIG_TRIM_UNUSED_KSYMS" ]; then
 	echo "#define __KSYM_module_layout 1" >> "$new_ksyms_file"
 fi
 

> I'm trying to determine the best way to fix it. Stay tuned.

Will do. I'm curious to see what a proper fix might look like.

Thanks,


Paul Bolle