Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933693AbcLAUlY (ORCPT ); Thu, 1 Dec 2016 15:41:24 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:36206 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932167AbcLAUlX (ORCPT ); Thu, 1 Dec 2016 15:41:23 -0500 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op In-Reply-To: <20161130232633.GS21645@lunn.ch> References: <20161130225930.25510-1-vivien.didelot@savoirfairelinux.com> <20161130225930.25510-4-vivien.didelot@savoirfairelinux.com> <20161130232633.GS21645@lunn.ch> Date: Thu, 01 Dec 2016 15:41:20 -0500 Message-ID: <87vav3gz67.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 39 Hi Andrew, Andrew Lunn writes: >> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> index ab52c37..9e51405 100644 >> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> @@ -765,6 +765,9 @@ struct mv88e6xxx_ops { >> int (*phy_write)(struct mv88e6xxx_chip *chip, int addr, int reg, >> u16 val); >> >> + /* Switch Software Reset */ >> + int (*reset)(struct mv88e6xxx_chip *chip); >> + > > Hi Vivien > > In my huge patch series of 6390, i've been using a g1_ prefix for > functionality which is in global 1, g2_ for global 2, etc. This has > worked for everything so far with the exception of setting which > reserved MAC addresses should be sent to the CPU. Most devices have it > in g2, but 6390 has it in g1. > > Please could you add the prefix. I don't understand. It looks like you are talking about the second part of the comment I made on your RFC patchset, about the Rsvd2CPU feature: https://www.mail-archive.com/netdev@vger.kernel.org/msg139837.html Switch reset routines are implemented in this patch in global1.c as mv88e6185_g1_reset and mv88e6352_g1_reset. 6185 and 6352 are implementation references for other switches. Thanks, Vivien