Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758934AbcLAWqa (ORCPT ); Thu, 1 Dec 2016 17:46:30 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:48599 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657AbcLAWq2 (ORCPT ); Thu, 1 Dec 2016 17:46:28 -0500 X-Auth-Info: iL5u+cR1r7VJ5hhCcEUDHwav4o4AtUGXwJ5BtqlpLLo= Date: Thu, 1 Dec 2016 23:45:23 +0100 From: Anatolij Gustschin To: Joshua Clayton Cc: Alan Tull , Moritz Fischer , Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/3] lib: add bitrev8x4() Message-ID: <20161201234523.3bed63dc@crub> In-Reply-To: References: X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 25 On Thu, 1 Dec 2016 09:04:50 -0800 Joshua Clayton stillcompiling@gmail.com wrote: ... >diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h >index ec291c3..6d2e9ca 100644 >--- a/arch/arm/include/asm/bitrev.h >+++ b/arch/arm/include/asm/bitrev.h >@@ -17,4 +17,9 @@ static __always_inline __attribute_const__ u8 __arch_bitrev8(u8 x) > return __arch_bitrev32((u32)x) >> 24; > } > >+static __always_inline __attribute_const__ u32 __arch_bitrev8x4(u32 x) >+{ >+ __asm__ ("rbit %0, %1; rev %0, %0" : "=r" (x) : "r" (x)); return x; >+} otherwise you get In function '__arch_bitrev8x4': warning: no return statement in function returning non-void [-Wreturn-type] -- Anatolij