Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759716AbcLBAhV (ORCPT ); Thu, 1 Dec 2016 19:37:21 -0500 Received: from mail.kernel.org ([198.145.29.136]:45534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759051AbcLBAfP (ORCPT ); Thu, 1 Dec 2016 19:35:15 -0500 From: Andy Lutomirski To: x86@kernel.org Cc: One Thousand Gnomes , Borislav Petkov , "linux-kernel@vger.kernel.org" , Brian Gerst , Matthew Whitehead , Henrique de Moraes Holschuh , Peter Zijlstra , Andy Lutomirski Subject: [PATCH v2 0/6] CPUID-less CPU/sync_core fixes and improvements Date: Thu, 1 Dec 2016 16:34:56 -0800 Message-Id: X-Mailer: git-send-email 2.9.3 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1650 Lines: 41 *** PATCHES 1 and 2 MAY BE 4.9 MATERIAL *** Alan Cox pointed out that the 486 isn't the only supported CPU that doesn't have CPUID. Let's clean up the mess and make everything faster while we're at it. Patch 1 is intended to be an easy fix: it makes sync_core() work without CPUID on all 32-bit kernels. It should be quite safe. This will have a negligible performance cost during boot on kernels built for newer CPUs. With this in place, patch 2 reverts the buggy 486 check I added. Patches 3-6 are meant to improve the situation. Patch 3 cleans up the Intel microcode loader and the rest (which depend on patch 3) stops using CPUID in sync_core() altogether. Changes from v1: - Fix Xen - Add timing info to the changelog (hint: 2x speedup) - Document patch 1 a bit better. Andy Lutomirski (6): x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit kernels Revert "x86/boot: Fail the boot if !M486 and CPUID is missing" x86/microcode/intel: Replace sync_core() with cpuid_eax(1) x86/paravirt: Make sync_core() be a paravirt op x86/xen: Add a Xen-specific sync_core() implementation x86/asm: Change sync_core() to use MOV to CR2 to serialize arch/x86/boot/cpu.c | 6 ------ arch/x86/include/asm/paravirt.h | 5 +++++ arch/x86/include/asm/paravirt_types.h | 2 ++ arch/x86/include/asm/processor.h | 34 ++++++++++------------------------ arch/x86/kernel/cpu/microcode/intel.c | 6 +++--- arch/x86/kernel/paravirt.c | 2 ++ arch/x86/xen/enlighten.c | 35 +++++++++++++++++++++++++++++++++++ 7 files changed, 57 insertions(+), 33 deletions(-) -- 2.9.3