From: Meng Yi <meng.yi@nxp.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
CC: "a.zummo@towertech.it" <a.zummo@towertech.it>,
        "rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH] rtc/nxp: add FTM alarm driver as the wakeup source
Thread-Topic: [RFC PATCH] rtc/nxp: add FTM alarm driver as the wakeup source
Thread-Index: AQHSLZmfOcr+I159UUKSnEgqrnRCnaDFZ7EwgC0R3gCAAbF/oA==
Date: Fri, 2 Dec 2016 02:27:06 +0000
Message-ID: <DB6PR0401MB26316D0BABB3652FB008D931EC8E0@DB6PR0401MB2631.eurprd04.prod.outlook.com>
References: <1477273336-48449-1-git-send-email-meng.yi@nxp.com>
 <DB6PR0401MB263163BD3E6AF420934DC6FAECA00@DB6PR0401MB2631.eurprd04.prod.outlook.com>
 <20161201003222.ih3lxuyfv7xyaget@piout.net>
In-Reply-To: <20161201003222.ih3lxuyfv7xyaget@piout.net>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2016 02:27:06.3428
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2632
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB22RKix017655
Content-Length: 809
Lines: 33

> > > +
> > > +static int nxp_ftm_rtc_read_time(struct device *dev, struct
> > > +rtc_time
> > > +*tm) {
> > > +	struct timeval time;
> > > +	unsigned long local_time;
> > > +
> > > +	do_gettimeofday(&time);
> > > +	local_time = (u32)(time.tv_sec - (sys_tz.tz_minuteswest * 60));
> > > +	rtc_time_to_tm(local_time, tm);
> > > +
> > > +	return 0;
> > > +}
> > > +
> >
> > This is not really getting time from the RTC since FTM is not a RTC
> > device, But we need to get the time to setup alarm, so we are using system
> time for now.
> > Anybody have better idea?
> >
> 
> No, that seems fine to me. I'll review the rest of the driver.

Thanks for your review, any feedback is welcomed!

> 
> 
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Meng