Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976AbcLBEPE (ORCPT ); Thu, 1 Dec 2016 23:15:04 -0500 Received: from ozlabs.org ([103.22.144.67]:42219 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbcLBEPC (ORCPT ); Thu, 1 Dec 2016 23:15:02 -0500 From: Michael Ellerman To: yanjiang.jin@windriver.com, benh@kernel.crashing.org, paulus@samba.org, oss@buserror.net Cc: linuxppc-dev@lists.ozlabs.org, yanjiang.jin@windriver.com, linux-kernel@vger.kernel.org, jinyanjiang@gmail.com Subject: Re: [PATCH] powerpc: cputime: fix a compile warning In-Reply-To: <1479704219-21403-1-git-send-email-yanjiang.jin@windriver.com> References: <1479704219-21403-1-git-send-email-yanjiang.jin@windriver.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 02 Dec 2016 15:15:00 +1100 Message-ID: <874m2n7yrf.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 18 yanjiang.jin@windriver.com writes: > diff --git a/arch/powerpc/include/asm/cputime.h b/arch/powerpc/include/asm/cputime.h > index 4f60db0..4423e97 100644 > --- a/arch/powerpc/include/asm/cputime.h > +++ b/arch/powerpc/include/asm/cputime.h > @@ -228,7 +228,8 @@ static inline cputime_t clock_t_to_cputime(const unsigned long clk) > return (__force cputime_t) ct; > } > > -#define cputime64_to_clock_t(ct) cputime_to_clock_t((cputime_t)(ct)) > +#define cputime64_to_clock_t(ct) \ > + (__force u64)(cputime_to_clock_t((cputime_t)(ct))) Given the name of the function is "cputime64 to clock_t", surely we should be returning a clock_t ? cheers