Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755173AbcLBEsJ (ORCPT ); Thu, 1 Dec 2016 23:48:09 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:49318 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbcLBEsH (ORCPT ); Thu, 1 Dec 2016 23:48:07 -0500 X-AuditID: cbfee61a-f79916d0000062de-cb-5840fd0491c2 From: Shailendra Verma To: Mauro Carvalho Chehab , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Junghak Sung , Julia Lawall , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] exynos-gsc: Clean up file handle in open() error path. Date: Fri, 02 Dec 2016 10:15:27 +0530 Message-id: <1480653927-6850-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t9jAV3Wvw4RBkf3slq8ebuGyWL78Vfs FssenGa06H/8mtni/PkN7BabHl9jtbi8aw6bRc+GrawWM87vY7JYtukPk8WteTPZLBZ9e8Vs 8ffiJTYHXo+ds+6ye2xa1cnmsXdLlsfmJfUeW/qBIn1bVjF6fN4kF8Ae5WaTkZqYklqkkJqX nJ+SmZduqxQa4qZroaSQl5ibaqsUoesbEqSkUJaYUwrkGRmgAQfnAPdgJX27BLeMPSvnsBR8 Z624OeUaYwNjK2sXIyeHhICJxIlNC5ggbDGJC/fWs3UxcnEICSxllFjy7zuU85NRovnIUrAq NgFDidd9f5lAEiICz5glnu7uYwdJMAvISOyb2AZWJCzgLjFl4g8WEJtFQFViUftnNhCbFyj+ /P9s5i5GDqB1ChJzJtlMYORewMiwilEitSC5oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM44J9J 7WA8uMv9EKMAB6MSD+8LY4cIIdbEsuLK3EOMEhzMSiK8fb+AQrwpiZVVqUX58UWlOanFhxhN gfZPZJYSTc4HRmNeSbyhibmJubGBhbmlpYmRkjhv4+xn4UIC6YklqdmpqQWpRTB9TBycUg2M q95n/vJTDNFUTPRdyu/8Tj9l8Ue+wqVb75sV2i7Iybdb9OtgSEy9cqCdyftFM94++nExOJKz gOWeyDnj5xZBj4TDoqeu+ZUbk9x2N8hL03qz6WKLOyxq+lEVb1elpuYLKt5Q9Y5/vU2bO322 fp2Gxjatf/VH/iyoFjlpNeX9eltfoxi59jtKLMUZiYZazEXFiQDmh8rljgIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 24 The File handle is not yet added in the vfd list.So no need to call v4l2_fh_del(&ctx->fh) if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c index 9f03b79..5ea97c1 100644 --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c @@ -664,8 +664,8 @@ static int gsc_m2m_open(struct file *file) error_ctrls: gsc_ctrls_delete(ctx); -error_fh: v4l2_fh_del(&ctx->fh); +error_fh: v4l2_fh_exit(&ctx->fh); kfree(ctx); unlock: -- 1.7.9.5