Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757519AbcLBEue (ORCPT ); Thu, 1 Dec 2016 23:50:34 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:55995 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbcLBEuc (ORCPT ); Thu, 1 Dec 2016 23:50:32 -0500 X-AuditID: cbfee61b-f796f6d000004092-e1-5840fd9087e4 From: Shailendra Verma To: Mauro Carvalho Chehab , Fabien Dessenne , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shailendra Verma , Shailendra Verma Cc: vidushi.koul@samsung.com Subject: [PATCH] bdisp: Clean up file handle in open() error path. Date: Fri, 02 Dec 2016 10:18:01 +0530 Message-id: <1480654081-6983-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t9jQd0Jfx0iDG4eFrI4tm47o8XlXXPY LHo2bGW1WLbpD5PFrXkz2SwWfXvFbPH34iU2B3aPnbPusntsWtXJ5tG3ZRWjx9Mfe5k9Pm+S C2CNcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINz gHuwkr5dglvG677bTAUT2SrezrjL3sA4n7WLkZNDQsBE4uCcBWwQtpjEhXvrgWwuDiGBWYwS zWsmMIMkhAR+Mkosv8cNYrMJGEq87vvLBFIkAhKfOXs9WDezgIzEvoltTCC2sICTxLn2w+wg NouAqsSCKV/ABvEKuEvMPTgRqJ4DaJuCxJxJNhMYuRcwMqxilEgtSC4oTkrPNcpLLdcrTswt Ls1L10vOz93ECA7RZ9I7GA/vcj/EKMDBqMTDG9DvECHEmlhWXJl7iFGCg1lJhLfvF1CINyWx siq1KD++qDQntfgQoynQ/onMUqLJ+cD4ySuJNzQxNzE3NrAwt7Q0MVIS522c/SxcSCA9sSQ1 OzW1ILUIpo+Jg1OqgXGjp/wJTqeHAQoGDX/Lrf+Fy96VPtft428S/TTe22jrRaUmAcabnpmd y6rCy75nCS43O+49W5CB2eaP3YYVy6KXuhY+LH6paX+YxYrDMWZDZKyLV+dOuRsRLeLWM9YU XAj9cmLG7sidwVdfrzZxSnCZcMIwsKbyulXaJuuOTJnbVX2apsqrlViKMxINtZiLihMBmUXO P2cCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 24 The File handle is not yet added in the vdev list.So no need to call v4l2_fh_del(&ctx->fh)if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index 45f82b5..fbf302f 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -632,8 +632,8 @@ static int bdisp_open(struct file *file) error_ctrls: bdisp_ctrls_delete(ctx); -error_fh: v4l2_fh_del(&ctx->fh); +error_fh: v4l2_fh_exit(&ctx->fh); bdisp_hw_free_nodes(ctx); mem_ctx: -- 1.7.9.5